Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issue 3006983002: Fix for using enums as InterfaceType(s) when resynthesize from Kernel. (Closed)

Created:
3 years, 3 months ago by scheglov
Modified:
3 years, 3 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix for using enums as InterfaceType(s) when resynthesize from Kernel. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/d1988c9c7f5e238e4fab6bb7a505a2da5d206ad3

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -11 lines) Patch
M pkg/analyzer/lib/src/dart/element/element.dart View 3 chunks +10 lines, -6 lines 0 comments Download
M pkg/analyzer/lib/src/kernel/resynthesize.dart View 1 chunk +16 lines, -0 lines 2 comments Download
M pkg/analyzer/test/src/summary/resynthesize_kernel_test.dart View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
scheglov
3 years, 3 months ago (2017-08-31 19:34:29 UTC) #1
Brian Wilkerson
https://codereview.chromium.org/3006983002/diff/1/pkg/analyzer/lib/src/kernel/resynthesize.dart File pkg/analyzer/lib/src/kernel/resynthesize.dart (right): https://codereview.chromium.org/3006983002/diff/1/pkg/analyzer/lib/src/kernel/resynthesize.dart#newcode749 pkg/analyzer/lib/src/kernel/resynthesize.dart:749: return null; Does this mean that we won't be ...
3 years, 3 months ago (2017-08-31 19:54:15 UTC) #2
scheglov
https://codereview.chromium.org/3006983002/diff/1/pkg/analyzer/lib/src/kernel/resynthesize.dart File pkg/analyzer/lib/src/kernel/resynthesize.dart (right): https://codereview.chromium.org/3006983002/diff/1/pkg/analyzer/lib/src/kernel/resynthesize.dart#newcode749 pkg/analyzer/lib/src/kernel/resynthesize.dart:749: return null; On 2017/08/31 19:54:15, Brian Wilkerson wrote: > ...
3 years, 3 months ago (2017-08-31 19:55:23 UTC) #3
Brian Wilkerson
Ok, lgtm.
3 years, 3 months ago (2017-08-31 20:10:53 UTC) #4
scheglov
3 years, 3 months ago (2017-08-31 21:06:57 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d1988c9c7f5e238e4fab6bb7a505a2da5d206ad3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698