Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2712)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 3006963002: Add missing copyright on test cases. (Closed)

Created:
3 years, 3 months ago by ahe
Modified:
3 years, 3 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add missing copyright on test cases. Also rename void-methods.dart to void_methods.dart. R=johnniwinther@google.com Committed: https://github.com/dart-lang/sdk/commit/893b4d4fe9580ccd89bad6886409b6339d6b4d1e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -71 lines) Patch
M pkg/front_end/testcases/argument.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/ast_builder.status View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/bad_store.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/call.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/closure.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/compile.status View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/escape.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/fallthrough.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/micro.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/optional.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/override.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/prefer_baseclass.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/redirecting_factory.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/static_setter.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/strong.status View 1 chunk +1 line, -1 line 0 comments Download
D pkg/front_end/testcases/void-methods.dart View 1 chunk +0 lines, -12 lines 0 comments Download
D pkg/front_end/testcases/void-methods.dart.direct.expect View 1 chunk +0 lines, -21 lines 0 comments Download
D pkg/front_end/testcases/void-methods.dart.outline.expect View 1 chunk +0 lines, -17 lines 0 comments Download
D pkg/front_end/testcases/void-methods.dart.strong.expect View 1 chunk +0 lines, -21 lines 0 comments Download
A pkg/front_end/testcases/void_methods.dart View 1 chunk +16 lines, -0 lines 0 comments Download
A + pkg/front_end/testcases/void_methods.dart.direct.expect View 0 chunks +-1 lines, --1 lines 0 comments Download
A + pkg/front_end/testcases/void_methods.dart.outline.expect View 0 chunks +-1 lines, --1 lines 0 comments Download
A + pkg/front_end/testcases/void_methods.dart.strong.expect View 0 chunks +-1 lines, --1 lines 0 comments Download
M pkg/front_end/tool/example.dart View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
ahe
Only need one reviewer.
3 years, 3 months ago (2017-08-31 10:39:37 UTC) #3
Johnni Winther
lgtm
3 years, 3 months ago (2017-08-31 10:44:54 UTC) #4
ahe
3 years, 3 months ago (2017-08-31 11:09:28 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
893b4d4fe9580ccd89bad6886409b6339d6b4d1e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698