Issue 3006893002: Refactor fuzzy arrow hints.

Issue 3006893002: Refactor fuzzy arrow hints. (Closed)

Created:
3 years, 3 months ago by Leaf

Modified:
3 years, 3 months ago

Reviewers:
Jennifer Messerly

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Reland and refactor fuzzy arrow hints. This restores the functionality from https://codereview.chromium.org/3012593002/, with some small refactors. The test breakage that caused the revert is fixed in https://codereview.chromium.org/3004143002/ . Also adds a couple of drive by fuzzy arrow fixes. BUG= R=jmesserly@google.com Committed: https://github.com/dart-lang/sdk/commit/1c94f7a604248843492b4cd4c56df43315d28c5e

Created: 3 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -12 lines)			Patch
M	pkg/analyzer/lib/error/error.dart	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	pkg/analyzer/lib/src/dart/analysis/driver.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analyzer/lib/src/dart/error/hint_codes.dart	View	1	1 chunk	+12 lines, -0 lines	0 comments	Download
M	pkg/analyzer/lib/src/task/strong/checker.dart	View	1	3 chunks	+18 lines, -1 line	0 comments	Download
M	pkg/analyzer/test/src/task/strong/checker_test.dart	View	1	6 chunks	+8 lines, -8 lines	0 comments	Download
M	pkg/compiler/analysis_options.yaml	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
M	pkg/dev_compiler/lib/src/js_ast/type_printer.dart	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	pkg/front_end/analysis_options.yaml	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Total messages: 8 (3 generated)

Leaf

PTAL. The original patch was reverted, this CL re-lands the refactored code, along with a ...

3 years, 3 months ago (2017-08-31 18:07:55 UTC) #4

Leaf

3 years, 3 months ago (2017-08-31 19:18:58 UTC) #8

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
1c94f7a604248843492b4cd4c56df43315d28c5e (presubmit successful).