Make service protocol respect isolate lifecycle

runtime/vm/service_event.cc

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/service_event.h"
 
 #include "vm/debugger.h"
 #include "vm/message_handler.h"
 #include "vm/service_isolate.h"
 
@@ skipping 18 matching lines @@
       inspectee_(NULL),
       gc_stats_(NULL),
       bytes_(NULL),
       bytes_length_(0),
       timestamp_(OS::GetCurrentTimeMillis()) {
   // We should never generate events for the vm or service isolates.
   ASSERT(isolate_ != Dart::vm_isolate());
   ASSERT(isolate == NULL ||
          !ServiceIsolate::IsServiceIsolateDescendant(isolate_));
 
-  if ((event_kind == ServiceEvent::kPauseStart) &&
-      !isolate->message_handler()->is_paused_on_start()) {
-    // We will pause on start but the message handler lacks a valid
-    // paused timestamp because we haven't paused yet. Use the current time.
-    timestamp_ = OS::GetCurrentTimeMillis();
-  } else if ((event_kind == ServiceEvent::kPauseStart) ||
-             (event_kind == ServiceEvent::kPauseExit)) {
+  if ((event_kind == ServiceEvent::kPauseStart) ||
+      (event_kind == ServiceEvent::kPauseExit)) {
     timestamp_ = isolate->message_handler()->paused_timestamp();
   } else if (event_kind == ServiceEvent::kResume) {
     timestamp_ = isolate->last_resume_timestamp();
   }
+  ASSERT(timestamp_ > -1);
 }
 
 void ServiceEvent::UpdateTimestamp() {
   timestamp_ = OS::GetCurrentTimeMillis();
 }
 
 const char* ServiceEvent::KindAsCString() const {
   switch (kind()) {
     case kVMUpdate:
       return "VMUpdate";
@@ skipping 213 matching lines @@
   } else {
     jsobj->AddProperty("isolate", isolate());
   }
   ASSERT(timestamp_ != -1);
   jsobj->AddPropertyTimeMillis("timestamp", timestamp_);
 }
 
 #endif  // !PRODUCT
 
 }  // namespace dart