Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 3006873002: [dart:io] Adds Platform.operatingSystemVersion (Closed)

Created:
3 years, 3 months ago by zra
Modified:
3 years, 3 months ago
Reviewers:
bkonyi, rmacnak, kevmoo
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[dart:io] Adds Platform.operatingSystemVersion fixes #30018 R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/e2bce948ed8f0bb6caf3918f77d3e66e2b39e8cd

Patch Set 1 #

Patch Set 2 : Windows support #

Patch Set 3 : Windows fixes #

Patch Set 4 : Mac support #

Patch Set 5 : Update patch files #

Patch Set 6 : Updated CHANGELOG #

Unified diffs Side-by-side diffs Delta from patch set Stats (+249 lines, -13 lines) Patch
M CHANGELOG.md View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/dev_compiler/tool/input_sdk/patch/io_patch.dart View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/bin/io_natives.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/bin/platform.h View 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/bin/platform.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M runtime/bin/platform_android.cc View 1 2 2 chunks +26 lines, -3 lines 0 comments Download
M runtime/bin/platform_fuchsia.cc View 1 2 3 4 2 chunks +23 lines, -0 lines 0 comments Download
M runtime/bin/platform_linux.cc View 1 2 2 chunks +26 lines, -3 lines 0 comments Download
M runtime/bin/platform_macos.cc View 1 2 3 2 chunks +28 lines, -5 lines 0 comments Download
M runtime/bin/platform_patch.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/bin/platform_win.cc View 1 2 1 chunk +83 lines, -0 lines 0 comments Download
M sdk/lib/_internal/js_runtime/lib/io_patch.dart View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
M sdk/lib/io/platform.dart View 2 chunks +6 lines, -0 lines 0 comments Download
M sdk/lib/io/platform_impl.dart View 1 2 2 chunks +14 lines, -2 lines 0 comments Download
A tests/standalone/io/platform_os_version_test.dart View 1 2 3 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
zra
3 years, 3 months ago (2017-08-31 18:27:00 UTC) #2
kevmoo
DBR: please add an entry to the CHANGELOG!
3 years, 3 months ago (2017-08-31 20:32:31 UTC) #4
rmacnak
lgtm
3 years, 3 months ago (2017-09-01 20:42:06 UTC) #5
zra
3 years, 3 months ago (2017-09-02 05:08:53 UTC) #7
Message was sent while issue was closed.
Committed patchset #6 (id:100001) manually as
e2bce948ed8f0bb6caf3918f77d3e66e2b39e8cd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698