Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 3006863002: Made helpers strong-mode clean for Dart 2.0 migration. (Closed)

Created:
3 years, 3 months ago by bkonyi
Modified:
3 years, 3 months ago
Reviewers:
zra
CC:
reviews_dartlang.org, rmacnak
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Made helpers strong-mode clean for Dart 2.0 migration. BUG= Committed: https://github.com/dart-lang/sdk/commit/07d16559f2d1a87558e864b12d7ce0ac6ad95e7e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -18 lines) Patch
M tests/lib/mirrors/declarations_model.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M tests/lib/mirrors/declarations_model_easier.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/lib_2/mirrors/declarations_model.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M tests/lib_2/mirrors/declarations_model_easier.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/lib_strong/mirrors/declarations_model.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M tests/lib_strong/mirrors/declarations_model_easier.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
bkonyi
Committed patchset #1 (id:1) manually as 07d16559f2d1a87558e864b12d7ce0ac6ad95e7e.
3 years, 3 months ago (2017-08-30 16:51:47 UTC) #2
bkonyi
3 years, 3 months ago (2017-08-30 16:57:06 UTC) #4
zra
3 years, 3 months ago (2017-08-30 17:02:14 UTC) #5
Message was sent while issue was closed.
lgtm, but I am probably not the right reviewer for this.

Powered by Google App Engine
This is Rietveld 408576698