Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 300683011: Fix potential flakiness of fast/css/fontface-methods.html (Closed)

Created:
6 years, 7 months ago by Kunihiko Sakamoto
Modified:
6 years, 7 months ago
Reviewers:
bashi
CC:
blink-reviews
Visibility:
Public.

Description

Fix potential flakiness of fast/css/fontface-methods.html The test is asserting that the FontFace status is "loading" right after load(), but since Ahem.ttf are loaded by the three test cases, it can be "loaded" if ResourceFetcher reuses the FontResource. To avoid this, adding dummy query strings to Ahem.ttf urls. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174939

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M LayoutTests/fast/css/fontface-methods.html View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Kunihiko Sakamoto
6 years, 7 months ago (2014-05-28 06:06:36 UTC) #1
bashi
On 2014/05/28 06:06:36, Kunihiko Sakamoto wrote: LGTM
6 years, 7 months ago (2014-05-28 06:08:45 UTC) #2
Kunihiko Sakamoto
The CQ bit was checked by ksakamoto@chromium.org
6 years, 7 months ago (2014-05-28 06:15:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ksakamoto@chromium.org/300683011/1
6 years, 7 months ago (2014-05-28 06:15:37 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-28 06:52:42 UTC) #5
Message was sent while issue was closed.
Change committed as 174939

Powered by Google App Engine
This is Rietveld 408576698