Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Unified Diff: src/debug.h

Issue 300683005: Rename EnterDebugger to DebugScope. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/debug.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/debug.h
diff --git a/src/debug.h b/src/debug.h
index 58c41c00fbdf090fe5c0a974b8b67e043b4bd339..06e60523fd3b9ddd2875fab810a2d6c7b44e2c36 100644
--- a/src/debug.h
+++ b/src/debug.h
@@ -25,7 +25,7 @@ namespace internal {
// Forward declarations.
-class EnterDebugger;
+class DebugScope;
// Step actions. NOTE: These values are in macros.py as well.
@@ -486,7 +486,7 @@ class Debug {
void AfterGarbageCollection();
// Flags and states.
- EnterDebugger* debugger_entry() { return thread_local_.debugger_entry_; }
+ DebugScope* debugger_entry() { return thread_local_.current_debug_scope_; }
inline Handle<Context> debug_context() { return debug_context_; }
void set_live_edit_enabled(bool v) { live_edit_enabled_ = v; }
bool live_edit_enabled() const {
@@ -496,8 +496,8 @@ class Debug {
inline bool is_active() const { return is_active_; }
inline bool is_loaded() const { return !debug_context_.is_null(); }
inline bool has_break_points() const { return has_break_points_; }
- inline bool is_entered() const {
- return thread_local_.debugger_entry_ != NULL;
+ inline bool in_debug_scope() const {
+ return thread_local_.current_debug_scope_ != NULL;
}
void set_disable_break(bool v) { break_disabled_ = v; }
@@ -577,6 +577,11 @@ class Debug {
Handle<Object> CheckBreakPoints(Handle<Object> break_point);
bool CheckBreakPoint(Handle<Object> break_point_object);
+ inline void AssertDebugContext() {
+ ASSERT(isolate_->context() == *debug_context());
+ ASSERT(in_debug_scope());
+ }
+
void ThreadInit();
// Global handles.
@@ -611,7 +616,7 @@ class Debug {
class ThreadLocal {
public:
// Top debugger entry.
- EnterDebugger* debugger_entry_;
+ DebugScope* current_debug_scope_;
// Counter for generating next break id.
int break_count_;
@@ -667,8 +672,7 @@ class Debug {
Isolate* isolate_;
friend class Isolate;
- friend class EnterDebugger;
- friend class FrameDropper;
+ friend class DebugScope;
friend class DisableBreak;
friend class SuppressDebug;
@@ -682,28 +686,29 @@ class Debug {
DECLARE_RUNTIME_FUNCTION(Debug_Break);
-// This class is used for entering the debugger. Create an instance in the stack
-// to enter the debugger. This will set the current break state, make sure the
-// debugger is loaded and switch to the debugger context. If the debugger for
-// some reason could not be entered FailedToEnter will return true.
-class EnterDebugger BASE_EMBEDDED {
+// This scope is used to load and enter the debug context and create a new
+// break state. Leaving the scope will restore the previous state.
+// On failure to load, FailedToEnter returns true.
+class DebugScope BASE_EMBEDDED {
public:
- explicit EnterDebugger(Isolate* isolate);
- ~EnterDebugger();
+ explicit DebugScope(Debug* debug);
+ ~DebugScope();
- // Check whether the debugger could be entered.
- inline bool FailedToEnter() { return load_failed_; }
+ // Check whether loading was successful.
+ inline bool failed() { return failed_; }
// Get the active context from before entering the debugger.
inline Handle<Context> GetContext() { return save_.context(); }
private:
- Isolate* isolate_;
- EnterDebugger* prev_; // Previous debugger entry if entered recursively.
+ Isolate* isolate() { return debug_->isolate_; }
+
+ Debug* debug_;
+ DebugScope* prev_; // Previous scope if entered recursively.
StackFrame::Id break_frame_id_; // Previous break frame id.
- int break_id_; // Previous break id.
- bool load_failed_; // Did the debugger fail to load?
- SaveContext save_; // Saves previous context.
+ int break_id_; // Previous break id.
+ bool failed_; // Did the debug context fail to load?
+ SaveContext save_; // Saves previous context.
};
« no previous file with comments | « no previous file | src/debug.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698