Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 3006693002: Add an integration test for kythe support with bug fixes (Closed)

Created:
3 years, 3 months ago by Brian Wilkerson
Modified:
3 years, 3 months ago
Reviewers:
jwren
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add an integration test for kythe support with bug fixes R=jwren@google.com Committed: https://github.com/dart-lang/sdk/commit/37042bb59bb07c2b391f57edb0a70b8b261e4c45

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+199 lines, -137 lines) Patch
M pkg/analysis_server/doc/api.html View 1 chunk +8 lines, -10 lines 0 comments Download
M pkg/analysis_server/lib/src/domain_kythe.dart View 1 chunk +6 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/kythe/kythe_visitors.dart View 9 chunks +36 lines, -28 lines 0 comments Download
M pkg/analysis_server/test/integration/coverage.md View 1 chunk +1 line, -1 line 0 comments Download
A pkg/analysis_server/test/integration/kythe/get_kythe_entries_test.dart View 1 chunk +39 lines, -0 lines 0 comments Download
A pkg/analysis_server/test/integration/kythe/test_all.dart View 1 chunk +13 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/integration/support/protocol_matchers.dart View 1 chunk +12 lines, -11 lines 0 comments Download
M pkg/analysis_server/test/integration/test_all.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/analysis_server/tool/spec/generated/java/types/KytheEntry.java View 4 chunks +25 lines, -19 lines 0 comments Download
M pkg/analyzer_plugin/doc/api.html View 1 chunk +8 lines, -10 lines 0 comments Download
M pkg/analyzer_plugin/lib/protocol/protocol_common.dart View 7 chunks +26 lines, -32 lines 0 comments Download
M pkg/analyzer_plugin/test/integration/support/protocol_matchers.dart View 1 chunk +12 lines, -11 lines 0 comments Download
M pkg/analyzer_plugin/test/plugin/kythe_mixin_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/analyzer_plugin/tool/spec/common_types_spec.html View 1 chunk +8 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
3 years, 3 months ago (2017-08-28 13:15:44 UTC) #2
jwren
On 2017/08/28 13:15:44, Brian Wilkerson wrote: LGTM
3 years, 3 months ago (2017-08-28 17:01:49 UTC) #3
Brian Wilkerson
3 years, 3 months ago (2017-08-28 17:07:09 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
37042bb59bb07c2b391f57edb0a70b8b261e4c45 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698