Issue 3006653003: Adding JRecord and boxing mechanics

Issue 3006653003: Adding JRecord and boxing mechanics (Closed)

Created:
3 years, 3 months ago by Emily Fortuna

Modified:
3 years, 3 months ago

Reviewers:
sra1

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Adding JRecord and boxing mechanics. Well, this introduces a few currently unused classes, but I'm trying to break the other CL up to figure out the source of the problem. BUG= R=sra@google.com Committed: https://github.com/dart-lang/sdk/commit/edd1ebfd6d3b825a2656cf84b699644afd5cb1d6

Created: 3 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+84 lines, -31 lines)			Patch
M	pkg/compiler/lib/src/js_backend/field_naming_mixin.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/compiler/lib/src/js_model/closure.dart	View	1	3 chunks	+43 lines, -7 lines	0 comments	Download
M	pkg/compiler/lib/src/kernel/element_map.dart	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	pkg/compiler/lib/src/kernel/element_map_impl.dart	View	1	1 chunk	+2 lines, -3 lines	0 comments	Download
M	pkg/compiler/lib/src/kernel/env.dart	View	1	2 chunks	+19 lines, -9 lines	0 comments	Download
M	pkg/compiler/lib/src/ssa/locals_handler.dart	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download
M	pkg/compiler/lib/src/universe/use.dart	View	1	3 chunks	+7 lines, -2 lines	0 comments	Download
M	tests/language_2/language_2_dart2js.status	View		1 chunk	+6 lines, -6 lines	0 comments	Download

Total messages: 9 (6 generated)

Emily Fortuna

strangely a different version of this supposedly identical CL (https://codereview.chromium.org/3010473002/) was causing the Stack Overflow ...

3 years, 3 months ago (2017-08-25 23:52:46 UTC) #3

sra1

lgtm suggest renames: JRecord --> JRecordField JRecordContainer -> JRecord

3 years, 3 months ago (2017-08-25 23:59:28 UTC) #6

Emily Fortuna

3 years, 3 months ago (2017-08-26 00:11:58 UTC) #9

Message was sent while issue was closed.

Committed patchset #3 (id:50009) manually as
edd1ebfd6d3b825a2656cf84b699644afd5cb1d6 (presubmit successful).