Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 3006653002: Work around breaking task_dependency_graph/check_test because of a bug in AnalysisContext with gene… (Closed)

Created:
3 years, 3 months ago by scheglov
Modified:
3 years, 3 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Work around breaking task_dependency_graph/check_test because of a bug in AnalysisContext with generalized functions. This fixes breaking after https://codereview.chromium.org/3010463002 TBR R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/5586741d92bf743d69f8fd21a394293cd6427f71

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M pkg/analyzer/lib/src/dart/analysis/driver.dart View 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 3 months ago (2017-08-25 21:43:59 UTC) #1
Brian Wilkerson
lgtm
3 years, 3 months ago (2017-08-25 21:45:25 UTC) #2
scheglov
3 years, 3 months ago (2017-08-25 21:47:51 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5586741d92bf743d69f8fd21a394293cd6427f71 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698