Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issue 3006633002: More clean-up prior to publishing (Closed)

Created:
3 years, 3 months ago by Brian Wilkerson
Modified:
3 years, 3 months ago
Reviewers:
devoncarew, Paul Berry
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -6 lines) Patch
M pkg/analyzer_plugin/pubspec.yaml View 1 chunk +7 lines, -6 lines 0 comments Download
M pkg/front_end/pubspec.yaml View 1 chunk +9 lines, -0 lines 4 comments Download

Messages

Total messages: 7 (2 generated)
Brian Wilkerson
3 years, 3 months ago (2017-08-25 21:02:06 UTC) #2
Paul Berry
https://codereview.chromium.org/3006633002/diff/1/pkg/front_end/pubspec.yaml File pkg/front_end/pubspec.yaml (right): https://codereview.chromium.org/3006633002/diff/1/pkg/front_end/pubspec.yaml#newcode9 pkg/front_end/pubspec.yaml:9: async_helper: Does pub allow the version to be the ...
3 years, 3 months ago (2017-08-25 21:04:53 UTC) #3
devoncarew
https://codereview.chromium.org/3006633002/diff/1/pkg/front_end/pubspec.yaml File pkg/front_end/pubspec.yaml (right): https://codereview.chromium.org/3006633002/diff/1/pkg/front_end/pubspec.yaml#newcode9 pkg/front_end/pubspec.yaml:9: async_helper: On 2017/08/25 21:04:52, Paul Berry wrote: > Does ...
3 years, 3 months ago (2017-08-25 21:08:29 UTC) #4
Brian Wilkerson
Committed patchset #1 (id:1) manually as 1f552d8c96c3d25dd3aaad41ac02de19d6b4ecd6 (presubmit successful).
3 years, 3 months ago (2017-08-25 21:11:51 UTC) #6
Brian Wilkerson
3 years, 3 months ago (2017-08-25 21:17:29 UTC) #7
Message was sent while issue was closed.
https://codereview.chromium.org/3006633002/diff/1/pkg/front_end/pubspec.yaml
File pkg/front_end/pubspec.yaml (right):

https://codereview.chromium.org/3006633002/diff/1/pkg/front_end/pubspec.yaml#...
pkg/front_end/pubspec.yaml:9: async_helper:
Sorry, I thought I had removed those lines. I have now.

Powered by Google App Engine
This is Rietveld 408576698