Issue 3006543002: Cache PackageBundle instances in AnalyzerWorkerLoop and reuse for multiple requests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3006543002: Cache PackageBundle instances in AnalyzerWorkerLoop and reuse for multiple requests. (Closed)

Created:
3 years, 3 months ago by scheglov

Modified:
3 years, 3 months ago

Reviewers:
Paul Berry, Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Cache PackageBundle instances in AnalyzerWorkerLoop and reuse for multiple requests. There are many Bazel targets that have huge number of dependencies, hundreds and thousands of them, and these dependencies are the same as for other targets. So, we want to keep corresponding PackageBundle instances, partially decoded, in memory and reuse. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/776b7eb9cdc8678cfbea851fa6ece1e514ce3ca0

Created: 3 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+151 lines, -9 lines)			Patch
M	pkg/analyzer_cli/lib/src/build_mode.dart	View	10 chunks	+149 lines, -8 lines	0 comments	Download
M	pkg/analyzer_cli/pubspec.yaml	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	pkg/analyzer_cli/test/build_mode_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (1 generated)

scheglov

3 years, 3 months ago (2017-08-24 18:32:26 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
776b7eb9cdc8678cfbea851fa6ece1e514ce3ca0 (presubmit successful).