Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1191)

Issue 300653002: Add support for I444 frames to VideoDecoderVpx. (Closed)

Created:
6 years, 7 months ago by Wez
Modified:
6 years, 7 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, chromoting-reviews_chromium.org
Visibility:
Public.

Description

Add support for I444 frames to VideoDecoderVpx. VideoDecoderVpx has supported VP9 for a while, but was missing a colour conversion codepath from I444 frames to ARGB. BUG=377239, 260879, 134202 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272846

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address review comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -75 lines) Patch
M remoting/codec/video_decoder_vpx.cc View 1 2 chunks +120 lines, -75 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Wez
6 years, 7 months ago (2014-05-25 01:49:41 UTC) #1
Wez
This is a minimal patch, in order to potentially be suitable for merge. I'll follow ...
6 years, 7 months ago (2014-05-25 01:52:15 UTC) #2
Sergey Ulanov
lgtm https://codereview.chromium.org/300653002/diff/1/remoting/codec/video_decoder_vpx.cc File remoting/codec/video_decoder_vpx.cc (right): https://codereview.chromium.org/300653002/diff/1/remoting/codec/video_decoder_vpx.cc#newcode298 remoting/codec/video_decoder_vpx.cc:298: LOG(ERROR) << ": fmt=" << last_image_->fmt; Change this ...
6 years, 7 months ago (2014-05-25 07:13:27 UTC) #3
Wez
https://codereview.chromium.org/300653002/diff/1/remoting/codec/video_decoder_vpx.cc File remoting/codec/video_decoder_vpx.cc (right): https://codereview.chromium.org/300653002/diff/1/remoting/codec/video_decoder_vpx.cc#newcode298 remoting/codec/video_decoder_vpx.cc:298: LOG(ERROR) << ": fmt=" << last_image_->fmt; On 2014/05/25 07:13:28, ...
6 years, 7 months ago (2014-05-25 22:59:11 UTC) #4
Wez
The CQ bit was checked by wez@chromium.org
6 years, 7 months ago (2014-05-25 22:59:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/300653002/20001
6 years, 7 months ago (2014-05-25 22:59:28 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-26 16:24:52 UTC) #7
Message was sent while issue was closed.
Change committed as 272846

Powered by Google App Engine
This is Rietveld 408576698