Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Unified Diff: pkg/analysis_server/lib/src/analysis_manager.dart

Issue 300643002: Use type annotations everywhere in analysis_server/lib. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Rollback using 'dynamic' type Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/bin/dartdeps.dart ('k') | pkg/analysis_server/lib/src/protocol.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/analysis_manager.dart
diff --git a/pkg/analysis_server/lib/src/analysis_manager.dart b/pkg/analysis_server/lib/src/analysis_manager.dart
index ce7f787992e532d88c8c88fe533eacfece581c54..59677e29a1c9c8659ee46d878d336dec3eeb85fc 100644
--- a/pkg/analysis_server/lib/src/analysis_manager.dart
+++ b/pkg/analysis_server/lib/src/analysis_manager.dart
@@ -50,7 +50,7 @@ class AnalysisManager {
*/
Future<AnalysisManager> _launchServer(String pathToServer) {
// TODO dynamically allocate port and/or allow client to specify port
- var serverArgs = [pathToServer, '--port', PORT.toString()];
+ List<String> serverArgs = [pathToServer, '--port', PORT.toString()];
return Process.start(Platform.executable, serverArgs)
.catchError((error) {
exitCode = 1;
@@ -81,7 +81,7 @@ class AnalysisManager {
})
.then((String line) {
String port = line.substring(pattern.length).trim();
- var url = 'ws://${InternetAddress.LOOPBACK_IP_V4.address}:$port/';
+ String url = 'ws://${InternetAddress.LOOPBACK_IP_V4.address}:$port/';
return _openConnection(url);
});
}
@@ -90,7 +90,7 @@ class AnalysisManager {
* Open a connection to the analysis server using the given URL.
*/
Future<AnalysisManager> _openConnection(String serverUrl) {
- var onError = (error) {
+ Function onError = (error) {
exitCode = 1;
if (process != null) {
process.kill();
« no previous file with comments | « pkg/analysis_server/bin/dartdeps.dart ('k') | pkg/analysis_server/lib/src/protocol.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698