Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 300623009: Fixes bugs in packet size computation in the creator and in the framer (Closed)

Created:
6 years, 7 months ago by ramant (doing other things)
Modified:
6 years, 7 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Fixes bugs in packet size computation in the creator and in the framer mostly related to truncated ack size computation and verification. Fixes a bug where sequence_number_length was incorrectly being allowed to change mid-packet, and actively updates lengths in packets at packet/FEC-group boundary. Adds tests to verify correct detection of ack truncation. Much yak hair was harvested, but no yaks were hurt in the making of this CL. Fixes bugs in packet-size computation in QuicPacketCreator and adds tests. Merge internal change: 67880898 R=rch@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+530 lines, -79 lines) Patch
M net/quic/quic_connection_test.cc View 3 chunks +16 lines, -8 lines 0 comments Download
M net/quic/quic_framer.h View 1 chunk +7 lines, -1 line 0 comments Download
M net/quic/quic_framer.cc View 5 chunks +32 lines, -27 lines 0 comments Download
M net/quic/quic_framer_test.cc View 12 chunks +245 lines, -21 lines 0 comments Download
M net/quic/quic_packet_creator.h View 1 chunk +4 lines, -3 lines 0 comments Download
M net/quic/quic_packet_creator.cc View 4 chunks +32 lines, -19 lines 0 comments Download
M net/quic/quic_packet_creator_test.cc View 4 chunks +161 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 1 chunk +5 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_utils.h View 1 chunk +5 lines, -0 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_utils.cc View 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ramant (doing other things)
6 years, 7 months ago (2014-05-27 23:37:47 UTC) #1
Ryan Hamilton
6 years, 7 months ago (2014-05-28 00:29:56 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698