Move NetworkTypePattern to its own file

chromeos/network/network_state_handler.h

Index: chromeos/network/network_state_handler.h
diff --git a/chromeos/network/network_state_handler.h b/chromeos/network/network_state_handler.h
index 07657786b0d7de8f902a22def88f852dc9c3eeef..9c6cc742fd085b5301239b01e7664e6b890231c2 100644
--- a/chromeos/network/network_state_handler.h
+++ b/chromeos/network/network_state_handler.h
@@ -19,6 +19,7 @@
 #include "chromeos/network/managed_state.h"
 #include "chromeos/network/network_handler.h"
 #include "chromeos/network/network_handler_callbacks.h"
+#include "chromeos/network/network_type_pattern.h"

[stevenjb, 2014/05/27 22:37:43]

Technically this can be forward declared, but since we are now using
NetworkTypePattern in so many function calls, this seems much more convenient
and easier to maintain.

[pneubeck (no reviews), 2014/05/28 08:04:02]

As usual, my preference is explicitness and include-what-you-use to make it
easier for new developers to read this code and trace definitions.

[stevenjb, 2014/05/28 15:44:17]

In general I agree, but I think there is also confusion/overhead when two
includes (three actually) are required to call, e.g., ConnectedNetworkByType().
I regret (and may change at some point) not including network_handler.h in each
network*handler.h since there is no useful way to access one without the other
(except in tests).

 #include "chromeos/network/shill_property_handler.h"
 
 namespace base {
@@ -37,7 +38,6 @@ class DeviceState;
 class NetworkState;
 class NetworkStateHandlerObserver;
 class NetworkStateHandlerTest;
-class NetworkTypePattern;
 
 // Class for tracking the list of visible networks and their properties.
 //