Fix issues with gathering third party repositories for bisect.

tools/bisect-perf-regression.py

 #!/usr/bin/env python
 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Performance Test Bisect Tool
 
 This script bisects a series of changelists using binary search. It starts at
 a bad revision where a performance metric has regressed, and asks for a last
 known-good revision. It will then binary search across this revision range by
@@ skipping 1411 matching lines @@
       deps_data = deps_data['deps']
 
       rxp = re.compile(".git@(?P<revision>[a-fA-F0-9]+)")
       results = {}
       for depot_name, depot_data in DEPOT_DEPS_NAME.iteritems():
         if (depot_data.get('platform') and
             depot_data.get('platform') != os.name):
           continue
 
         if (depot_data.get('recurse') and depot in depot_data.get('from')):
-          src_dir = depot_data.get('src') or depot_data.get('src_old')
+          src_dir = (deps_data.get(depot_data.get('src')) or
+                     deps_data.get(depot_data.get('src_old')))
           if src_dir:
             self.depot_cwd[depot_name] = os.path.join(self.src_cwd, src_dir[4:])
             re_results = rxp.search(deps_data.get(src_dir, ''))
             if re_results:
               results[depot_name] = re_results.group('revision')
             else:
               warning_text = ('Couldn\'t parse revision for %s while bisecting '
                              '%s' % (depot_name, depot))
               if not warning_text in self.warnings:
                 self.warnings.append(warning_text)
+          else:
+            results[depot_name] = None
       return results
     except ImportError:
       deps_file_contents = ReadStringFromFile(bisect_utils.FILE_DEPS_GIT)
       parse_results = self._ParseRevisionsFromDEPSFileManually(
           deps_file_contents)
       results = {}
       for depot_name, depot_revision in parse_results.iteritems():
         depot_revision = depot_revision.strip('@')
         print depot_name, depot_revision
         for current_name, current_data in DEPOT_DEPS_NAME.iteritems():
@@ skipping 1076 matching lines @@
       if not (DEPOT_DEPS_NAME[next_depot]["recurse"] and
           min_revision_data['depot'] in DEPOT_DEPS_NAME[next_depot]['from']):
         continue
 
       if current_depot == 'v8':
         # We grab the bleeding_edge info here rather than earlier because we
         # finally have the revision range. From that we can search forwards and
         # backwards to try to match trunk revisions to bleeding_edge.
         self._FillInV8BleedingEdgeInfo(min_revision_data, max_revision_data)
 
-      if (min_revision_data['external'][next_depot] ==
-          max_revision_data['external'][next_depot]):
+      if (min_revision_data['external'].get(next_depot) ==
+          max_revision_data['external'].get(next_depot)):
         continue
 
-      if (min_revision_data['external'][next_depot] and
-          max_revision_data['external'][next_depot]):
+      if (min_revision_data['external'].get(next_depot) and
+          max_revision_data['external'].get(next_depot)):
         external_depot = next_depot
         break
 
     return external_depot
 
   def PrepareToBisectOnDepot(self,
                              current_depot,
                              end_revision,
                              start_revision,
                              previous_depot,
@@ skipping 1339 matching lines @@
       # The perf dashboard scrapes the "results" step in order to comment on
       # bugs. If you change this, please update the perf dashboard as well.
       bisect_utils.OutputAnnotationStepStart('Results')
     print 'Error: %s' % e.message
     if opts.output_buildbot_annotations:
       bisect_utils.OutputAnnotationStepClosed()
   return 1
 
 if __name__ == '__main__':
   sys.exit(main())