Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Unified Diff: ui/gfx/render_text_harfbuzz.cc

Issue 300623003: Fix the Char to Glyph mapping logic in RenderTextHarfBuzz (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: compile fix 2 Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/gfx/render_text_harfbuzz.h ('k') | ui/gfx/render_text_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gfx/render_text_harfbuzz.cc
diff --git a/ui/gfx/render_text_harfbuzz.cc b/ui/gfx/render_text_harfbuzz.cc
index bd99f5edb6ed34b9b5a1d27bb3d09d783a52b3ae..06fe798376941b343f0d5fea669da91b0601951f 100644
--- a/ui/gfx/render_text_harfbuzz.cc
+++ b/ui/gfx/render_text_harfbuzz.cc
@@ -393,11 +393,11 @@ size_t TextRunHarfBuzz::CharToGlyph(size_t pos) const {
DCHECK(range.start() <= pos && pos < range.end());
if (!is_rtl) {
- for (size_t i = 0; i < glyph_count - 1; ++i) {
- if (pos < glyph_to_char[i + 1])
- return i;
- }
- return glyph_count - 1;
+ size_t cluster_start = 0;
+ for (size_t i = 1; i < glyph_count && pos >= glyph_to_char[i]; ++i)
+ if (glyph_to_char[i] != glyph_to_char[i - 1])
+ cluster_start = i;
+ return cluster_start;
}
for (size_t i = 0; i < glyph_count; ++i) {
@@ -408,16 +408,34 @@ size_t TextRunHarfBuzz::CharToGlyph(size_t pos) const {
return 0;
}
-Range TextRunHarfBuzz::CharRangeToGlyphRange(const Range& range) const {
- DCHECK(range.Contains(range));
- DCHECK(!range.is_reversed());
- DCHECK(!range.is_empty());
+Range TextRunHarfBuzz::CharRangeToGlyphRange(const Range& char_range) const {
+ DCHECK(range.Contains(char_range));
+ DCHECK(!char_range.is_reversed());
+ DCHECK(!char_range.is_empty());
+
+ size_t first = 0;
+ size_t last = 0;
+
+ if (is_rtl) {
+ // For RTL runs, we subtract 1 from |char_range| to get the leading edges.
+ last = CharToGlyph(char_range.end() - 1);
+ // Loop until we find a non-empty glyph range. For multi-character clusters,
+ // the loop is needed to find the cluster end. Do the same for LTR below.
+ for (size_t i = char_range.start(); i > range.start(); --i) {
+ first = CharToGlyph(i - 1);
+ if (first != last)
+ return Range(last, first);
+ }
+ return Range(last, glyph_count);
+ }
- const size_t first = CharToGlyph(range.start());
- const size_t last = CharToGlyph(range.end() - 1);
- // TODO(ckocagil): What happens when the character has zero or multiple
- // glyphs? Is the "+ 1" below correct then?
- return Range(std::min(first, last), std::max(first, last) + 1);
+ first = CharToGlyph(char_range.start());
+ for (size_t i = char_range.end(); i < range.end(); ++i) {
+ last = CharToGlyph(i);
+ if (first != last)
+ return Range(first, last);
+ }
+ return Range(first, glyph_count);
}
// Returns whether the given shaped run contains any missing glyphs.
« no previous file with comments | « ui/gfx/render_text_harfbuzz.h ('k') | ui/gfx/render_text_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698