Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 3006033002: Add completion of keywords in partial field declarations (Closed)

Created:
3 years, 3 months ago by Brian Wilkerson
Modified:
3 years, 3 months ago
Reviewers:
danrubel
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add completion of keywords in partial field declarations R=danrubel@google.com Committed: https://github.com/dart-lang/sdk/commit/28381b8f0617f5f52f5def91cbf52bca91455c31

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -0 lines) Patch
M pkg/analysis_server/lib/src/services/completion/dart/keyword_contributor.dart View 1 chunk +19 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/keyword_contributor_test.dart View 1 chunk +22 lines, -0 lines 2 comments Download

Messages

Total messages: 6 (2 generated)
Brian Wilkerson
3 years, 3 months ago (2017-09-03 14:14:45 UTC) #2
danrubel
LGTM https://codereview.chromium.org/3006033002/diff/1/pkg/analysis_server/test/services/completion/dart/keyword_contributor_test.dart File pkg/analysis_server/test/services/completion/dart/keyword_contributor_test.dart (right): https://codereview.chromium.org/3006033002/diff/1/pkg/analysis_server/test/services/completion/dart/keyword_contributor_test.dart#newcode754 pkg/analysis_server/test/services/completion/dart/keyword_contributor_test.dart:754: @soloTest Remove @soloTest here and below?
3 years, 3 months ago (2017-09-03 16:08:11 UTC) #3
Brian Wilkerson
Committed patchset #1 (id:1) manually as 28381b8f0617f5f52f5def91cbf52bca91455c31 (presubmit successful).
3 years, 3 months ago (2017-09-03 20:04:08 UTC) #5
Brian Wilkerson
3 years, 3 months ago (2017-09-03 20:04:18 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/3006033002/diff/1/pkg/analysis_server/test/se...
File
pkg/analysis_server/test/services/completion/dart/keyword_contributor_test.dart
(right):

https://codereview.chromium.org/3006033002/diff/1/pkg/analysis_server/test/se...
pkg/analysis_server/test/services/completion/dart/keyword_contributor_test.dart:754:
@soloTest
Done

Powered by Google App Engine
This is Rietveld 408576698