Issue 3006002: Fix uninitialized memory error caused by r50606.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3006002: Fix uninitialized memory error caused by r50606. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 10 months ago by pink

Modified:
4 years ago

Reviewers:
viettrungluu

CC:
chromium-reviews, Alexander Potapenko, ben+cc_chromium.org, John Grabowski, Timur Iskhodzhanov, stuartmorgan, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Fix uninitialized memory error caused by r50606. BUG=48269 TEST=none

Patch Set 1 #

Total comments: 1

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -12 lines)			Patch
	M	chrome/browser/cocoa/tab_window_controller.mm	View		1 chunk	+3 lines, -2 lines	1 comment	Download
	M	tools/valgrind/memcheck/suppressions_mac.txt	View		1 chunk	+0 lines, -10 lines	0 comments	Download

Trybot results: mac

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

4 years, 10 months ago (2010-07-15 17:55:34 UTC) #2

LGTM.

http://codereview.chromium.org/3006002/diff/1/2
File chrome/browser/cocoa/tab_window_controller.mm (left):

http://codereview.chromium.org/3006002/diff/1/2#oldcode69
chrome/browser/cocoa/tab_window_controller.mm:69: NSMakeRect(0,
NSMaxY(tabFrame),
I feel like the compiler should have noticed something amiss here.

Expand Messages | Collapse Messages