Make omaha, gcapi and uninstall registry accesses use Wow6432Node on 64-bit

chrome/installer/mini_installer/mini_installer.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // mini_installer.exe is the first exe that is run when chrome is being
 // installed or upgraded. It is designed to be extremely small (~5KB with no
 // extra resources linked) and it has two main jobs:
 //   1) unpack the resources (possibly decompressing some)
 //   2) run the real installer (setup.exe) with appropriate flags.
 //
@@ skipping 114 matching lines @@
 }
 
 // Helper function to read a value from registry. Returns true if value
 // is read successfully and stored in parameter value. Returns false otherwise.
 // |size| is measured in wchar_t units.
 bool ReadValueFromRegistry(HKEY root_key, const wchar_t *sub_key,
                            const wchar_t *value_name, wchar_t *value,
                            size_t size) {
   RegKey key;
 
-  if (key.Open(root_key, sub_key, KEY_QUERY_VALUE) == ERROR_SUCCESS &&
+  if (key.Open(root_key, sub_key,
+               KEY_QUERY_VALUE | KEY_WOW64_32KEY) == ERROR_SUCCESS &&

[grt (UTC plus 2), 2014/05/27 16:42:08]

this function is only used for a key in HKCU that isn't affected by WOW64. it
doesn't seem right to put the flag here.

[Will Harris, 2014/05/27 19:25:10]

Done.

       key.ReadValue(value_name, value, size) == ERROR_SUCCESS) {
     return true;
   }
   return false;
 }
 
 // Opens the Google Update ClientState key for a product.
 bool OpenClientStateKey(HKEY root_key, const wchar_t* app_guid, REGSAM access,

[grt (UTC plus 2), 2014/05/27 16:42:08]

since this helper accesses a key that always needs WOW64_32, how about OR-ing
the bit in on line 149 and remove it from the callers?

[Will Harris, 2014/05/27 19:25:10]

Done. Good idea.

                         RegKey* key) {
   PathString client_state_key;
   return client_state_key.assign(kApRegistryKeyBase) &&
          client_state_key.append(app_guid) &&
          (key->Open(root_key, client_state_key.get(), access) == ERROR_SUCCESS);
 }
 
 // This function sets the flag in registry to indicate that Google Update
 // should try full installer next time. If the current installer works, this
 // flag is cleared by setup.exe at the end of install. The flag will by default
 // be written to HKCU, but if --system-level is included in the command line,
 // it will be written to HKLM instead.
 // TODO(grt): Write a unit test for this that uses registry virtualization.
 void SetInstallerFlags(const Configuration& configuration) {
   RegKey key;
-  const REGSAM key_access = KEY_QUERY_VALUE | KEY_SET_VALUE;
+  const REGSAM key_access = KEY_QUERY_VALUE | KEY_SET_VALUE | KEY_WOW64_32KEY;
   const HKEY root_key =
       configuration.is_system_level() ? HKEY_LOCAL_MACHINE : HKEY_CURRENT_USER;
   // This is ignored if multi-install is true.
   const wchar_t* app_guid =
       configuration.has_chrome_frame() ?
           google_update::kChromeFrameAppGuid :
           configuration.chrome_app_guid();
   StackString<128> value;
   LONG ret;
 
@@ skipping 52 matching lines @@
 }
 
 // Gets the setup.exe path from Registry by looking the value of Uninstall
 // string.  |size| is measured in wchar_t units.
 bool GetSetupExePathForGuidFromRegistry(bool system_level,
                                         const wchar_t* app_guid,
                                         wchar_t* path,
                                         size_t size) {
   const HKEY root_key = system_level ? HKEY_LOCAL_MACHINE : HKEY_CURRENT_USER;
   RegKey key;
-  return OpenClientStateKey(root_key, app_guid, KEY_QUERY_VALUE, &key) &&
+  return OpenClientStateKey(root_key, app_guid,
+                            KEY_QUERY_VALUE | KEY_WOW64_32KEY, &key) &&
       (key.ReadValue(kUninstallRegistryValueName, path, size) == ERROR_SUCCESS);
 }
 
 // Gets the setup.exe path from Registry by looking the value of Uninstall
 // string.  |size| is measured in wchar_t units.
 bool GetSetupExePathFromRegistry(const Configuration& configuration,
                                  wchar_t* path,
                                  size_t size) {
   bool system_level = configuration.is_system_level();
 
@@ skipping 592 matching lines @@
 #pragma function(memset)
 void* memset(void* dest, int c, size_t count) {
   void* start = dest;
   while (count--) {
     *reinterpret_cast<char*>(dest) = static_cast<char>(c);
     dest = reinterpret_cast<char*>(dest) + 1;
   }
   return start;
 }
 }  // extern "C"