Issue 3005883002: [dart:io] Remove double-close from recursive directory delete

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3005883002: [dart:io] Remove double-close from recursive directory delete (Closed)

Created:
3 years, 3 months ago by zra

Modified:
3 years, 3 months ago

Reviewers:
bkonyi, rmacnak

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

[dart:io] Remove double-close from recursive directory delete closedir() closes the file descriptor wrapped by the DIR, so we shouldn't close it again. R=bkonyi@google.com Committed: https://github.com/dart-lang/sdk/commit/732bb45c45d1fd3b2c1e7ff7fb12ce93e6fa1dcc

Created: 3 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -6 lines)			Patch
M	runtime/bin/directory_android.cc	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	runtime/bin/directory_fuchsia.cc	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	runtime/bin/directory_linux.cc	View	2 chunks	+0 lines, -2 lines	0 comments	Download

Total messages: 5 (2 generated)

zra

3 years, 3 months ago (2017-08-30 19:49:10 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
732bb45c45d1fd3b2c1e7ff7fb12ce93e6fa1dcc (presubmit successful).