Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 3005863003: Fix many bots. (Closed)

Created:
3 years, 3 months ago by jcollins
Modified:
3 years, 3 months ago
Reviewers:
bkonyi, Bob Nystrom
CC:
reviews_dartlang.org, dart2now-team_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix many bots. This covers the following cases: python tools/test.py -m release -c dart2js -r d8 --minified --dart2js-with-kernel --use-sdk --dart2js-batch --reset-browser-configuration language_2/bad_constructor_test/05 python tools/test.py -m release -c dart2js -r d8 --minified --dart2js-with-kernel --use-sdk --dart2js-batch --reset-browser-configuration language_2/closures_with_complex_params_test python tools/test.py -m release -c dart2js -r d8 --minified --dart2js-with-kernel --use-sdk --dart2js-batch --reset-browser-configuration language_2/generic_async_star_test python tools/test.py -m release -c dart2js -r d8 --minified --dart2js-with-kernel --use-sdk --dart2js-batch --reset-browser-configuration language_2/generic_async_test python tools/test.py -m release -c dart2js -r d8 --minified --dart2js-with-kernel --use-sdk --dart2js-batch --reset-browser-configuration language_2/generic_field_mixin6_test/01 python tools/test.py -m release -c dart2js -r d8 --minified --dart2js-with-kernel --use-sdk --dart2js-batch --reset-browser-configuration language_2/generic_field_mixin6_test/none python tools/test.py -m release -c dart2js -r d8 --minified --dart2js-with-kernel --use-sdk --dart2js-batch --reset-browser-configuration language_2/generic_function_typedef_test/01 python tools/test.py -m release -c dart2js -r d8 --minified --dart2js-with-kernel --use-sdk --dart2js-batch --reset-browser-configuration language_2/generic_method_types_test/01 python tools/test.py -m release -c dart2js -r d8 --minified --dart2js-with-kernel --use-sdk --dart2js-batch --reset-browser-configuration language_2/generic_method_types_test/02 python tools/test.py -m release -c dart2js -r d8 --minified --dart2js-with-kernel --use-sdk --dart2js-batch --reset-browser-configuration language_2/typecheck_multifield_declaration_test python tools/test.py -m release -c dart2js -r d8 --minified --dart2js-with-kernel --use-sdk --dart2js-batch --reset-browser-configuration language_2/unused_overridden_async_test python tools/test.py -m release -c dart2js -r d8 --minified --dart2js-with-kernel --use-sdk --dart2js-batch --reset-browser-configuration language_2/vm/allocation_sinking_vm_test python tools/test.py -m release -c dart2js -r d8 --minified --dart2js-with-kernel --use-sdk --dart2js-batch --reset-browser-configuration language/reexport_core_test python tools/test.py -m release -c dartk language_2/bad_constructor_test/05 python tools/test.py -m release -c dartk language/reexport_core_test BUG= R=rnystrom@google.com Committed: https://github.com/dart-lang/sdk/commit/e31e61110157350ecd601bd49f86f9aea6729aa7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -9 lines) Patch
M tests/language/language_dart2js.status View 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/language_kernel.status View 1 chunk +1 line, -0 lines 0 comments Download
M tests/language_2/language_2_dart2js.status View 4 chunks +7 lines, -8 lines 0 comments Download
M tests/language_2/language_2_vm.status View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
jcollins
3 years, 3 months ago (2017-08-30 21:34:39 UTC) #2
Bob Nystrom
lgtm
3 years, 3 months ago (2017-08-30 21:53:00 UTC) #3
jcollins
3 years, 3 months ago (2017-08-30 21:55:38 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e31e61110157350ecd601bd49f86f9aea6729aa7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698