Handle forwarding constructors to unnamed mixin applications

pkg/compiler/lib/src/kernel/kernel_backend_strategy.dart

 // Copyright (c) 2017, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library dart2js.kernel.backend_strategy;
 
 import 'package:kernel/ast.dart' as ir;
 
 import '../backend_strategy.dart';
 import '../common.dart';
@@ skipping 215 matching lines @@
         if (r != 0) return r;
         MemberDefinition definition1 = elementMap.getMemberDefinition(member1);
         MemberDefinition definition2 = elementMap.getMemberDefinition(member2);
         return _compareSourceSpans(
             member1, definition1.location, member2, definition2.location);
       });
   }
 
   @override
   Iterable<ClassEntity> sortClasses(Iterable<ClassEntity> classes) {
-    return classes.toList()
-      ..sort((ClassEntity cls1, ClassEntity cls2) {
-        int r = _compareLibraries(cls1.library, cls2.library);
-        if (r != 0) return r;
-        ClassDefinition definition1 = elementMap.getClassDefinition(cls1);
-        ClassDefinition definition2 = elementMap.getClassDefinition(cls2);
-        return _compareSourceSpans(
-            cls1, definition1.location, cls2, definition2.location);
+    int compareClasses(ClassEntity cls1, ClassEntity cls2) {
+      int r = _compareLibraries(cls1.library, cls2.library);
+      if (r != 0) return r;
+      ClassDefinition definition1 = elementMap.getClassDefinition(cls1);
+      ClassDefinition definition2 = elementMap.getClassDefinition(cls2);
+      return _compareSourceSpans(
+          cls1, definition1.location, cls2, definition2.location);
+    }
+
+    ClassEntity getMixin(ClassEntity cls) {
+      ClassEntity mixin;
+      elementMap.elementEnvironment.forEachMixin(cls, (ClassEntity c) {

[Siggi Cherem (dart-lang), 2017/08/30 19:33:52]

maybe it is worth having a method to just fetch the first mixin?

+        if (c != null) return;

[Siggi Cherem (dart-lang), 2017/08/30 19:33:52]

seems like c/mixin are swapped here and below:

  if (mixin != null) return;
  mixin = c;

Or maybe just do:
  mixin ??= c

+        c = mixin;
       });
+      return mixin;
+    }
+
+    List<ClassEntity> regularClasses = <ClassEntity>[];
+    List<ClassEntity> unnamedMixins = <ClassEntity>[];
+    for (ClassEntity cls in classes) {
+      if (elementMap.elementEnvironment.isUnnamedMixinApplication(cls)) {
+        unnamedMixins.add(cls);
+      } else {
+        regularClasses.add(cls);
+      }
+    }
+    List<ClassEntity> sorted = <ClassEntity>[];
+    regularClasses.sort(compareClasses);
+    sorted.addAll(regularClasses);
+    unnamedMixins.sort((a, b) {
+      int result = a.name.compareTo(b.name);
+      if (result != 0) return result;
+      return compareClasses(getMixin(a), getMixin(b));

[Siggi Cherem (dart-lang), 2017/08/30 19:33:52]

should this be recursive instead?

e.g: compare A&B&C vs A&B&D ?

[Johnni Winther, 2017/09/01 15:17:45]

Remove the need for this. If we sort first by library their names are unique.

+    });
+    sorted.addAll(unnamedMixins);
+    return sorted;
   }
 
   @override
   Iterable<TypedefEntity> sortTypedefs(Iterable<TypedefEntity> typedefs) {
     // TODO(redemption): Support this.
     assert(typedefs.isEmpty);
     return typedefs;
   }
 }