Add stream operators for URLPattern and URLPatternSet and unit test for URLPatternSet

extensions/common/url_pattern_set.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/common/url_pattern_set.h"
 
 #include <iterator>
 
 #include "base/logging.h"
 #include "base/memory/linked_ptr.h"
@@ skipping 81 matching lines @@
 
 URLPatternSet& URLPatternSet::operator=(const URLPatternSet& rhs) {
   patterns_ = rhs.patterns_;
   return *this;
 }
 
 bool URLPatternSet::operator==(const URLPatternSet& other) const {
   return patterns_ == other.patterns_;
 }
 
+std::ostream& operator<<(std::ostream& out,
+                         const URLPatternSet& url_pattern_set) {
+  out << "{ ";

[Jeffrey Yasskin, 2014/05/28 22:32:04]

And <ostream>

[aboxhall, 2014/05/28 22:44:10]

Done.

+
+  using const_iterator = std::set<URLPattern>::const_iterator;

[Jeffrey Yasskin, 2014/05/28 22:32:04]

This is C++11 so won't work everywhere. Use typedef instead, or avoid the alias
since you're only using it once.

[aboxhall, 2014/05/28 22:44:10]

Done.

+  const_iterator iter = url_pattern_set.patterns().begin();
+  if (!url_pattern_set.patterns().empty()) {
+    out << *iter;
+    ++iter;
+  }
+
+  for (;iter != url_pattern_set.patterns().end(); ++iter)
+    out << ", " << *iter;
+
+  if (!url_pattern_set.patterns().empty())
+    out << " ";
+
+  out << "}";
+  return out;
+}
+
 bool URLPatternSet::is_empty() const {
   return patterns_.empty();
 }
 
 size_t URLPatternSet::size() const {
   return patterns_.size();
 }
 
 bool URLPatternSet::AddPattern(const URLPattern& pattern) {
   return patterns_.insert(pattern).second;
@@ skipping 103 matching lines @@
   for (size_t i = 0; i < value.GetSize(); ++i) {
     std::string item;
     if (!value.GetString(i, &item))
       return false;
     patterns.push_back(item);
   }
   return Populate(patterns, valid_schemes, allow_file_access, error);
 }
 
 }  // namespace extensions