Added ability to find builder-groups

Added ability to find builder-groups

Added calls to CBE, cleaned up the remaining screen-scraping and added ability to find builder-groups and builders in groups

R=johnniwinther@google.com

Committed: https://github.com/dart-lang/sdk/commit/dfd5038ecbd42328519418938b5e66b937b1bff6

[mkroghj, 2017-08-28 13:15:05]

mkroghj@google.com changed reviewers:
+ johnniwinther@google.com, whesse@google.com

[mkroghj, 2017-08-28 13:15:06]

ptal

[Johnni Winther, 2017-08-29 07:23:04]

lgtm

https://codereview.chromium.org/3005723002/diff/1/tools/gardening/lib/src/luc...
File tools/gardening/lib/src/luci_api.dart (right):

https://codereview.chromium.org/3005723002/diff/1/tools/gardening/lib/src/luc...
tools/gardening/lib/src/luci_api.dart:21: /// some information is found via CBE
(Chrome Built Extract)
-> `Chrome Build Extract` ?

https://codereview.chromium.org/3005723002/diff/1/tools/gardening/lib/src/luc...
tools/gardening/lib/src/luci_api.dart:28: /// [getBuilderGroups] fetches all
builder groups not in -dev, -stable and
Documentation doesn't seem to match the implementation.

https://codereview.chromium.org/3005723002/diff/1/tools/gardening/lib/src/luc...
tools/gardening/lib/src/luci_api.dart:30: Future<Try<dynamic>> getCBEJson(
Rename to [getJsonFromChromeBuildExtract]

https://codereview.chromium.org/3005723002/diff/1/tools/gardening/lib/src/luc...
tools/gardening/lib/src/luci_api.dart:39: /// Gets master information out for
all bots, which is not that
Remove ', which is not that useful atm'. Maybe add a TODO for you about want you
think it should/could be used for in the future.

[mkroghj, 2017-08-30 07:26:53]

Description was changed from

==========
Added ability to find builder-groups

Added calls to CBE, cleaned up the remaining screen-scraping and added ability
to find builder-groups and builders in groups
==========

to

==========
Added ability to find builder-groups

Added calls to CBE, cleaned up the remaining screen-scraping and added ability
to find builder-groups and builders in groups

R=johnniwinther@google.com

Committed:
https://github.com/dart-lang/sdk/commit/dfd5038ecbd42328519418938b5e66b937b1bff6
==========

[mkroghj, 2017-08-30 07:26:54]

Committed patchset #2 (id:20001) manually as
dfd5038ecbd42328519418938b5e66b937b1bff6 (presubmit successful).

[mkroghj, 2017-08-30 07:27:44]

https://codereview.chromium.org/3005723002/diff/1/tools/gardening/lib/src/luc...
File tools/gardening/lib/src/luci_api.dart (right):

https://codereview.chromium.org/3005723002/diff/1/tools/gardening/lib/src/luc...
tools/gardening/lib/src/luci_api.dart:21: /// some information is found via CBE
(Chrome Built Extract)
On 2017/08/29 07:23:04, Johnni Winther wrote:
> -> `Chrome Build Extract` ?

Done.

https://codereview.chromium.org/3005723002/diff/1/tools/gardening/lib/src/luc...
tools/gardening/lib/src/luci_api.dart:28: /// [getBuilderGroups] fetches all
builder groups not in -dev, -stable and
On 2017/08/29 07:23:04, Johnni Winther wrote:
> Documentation doesn't seem to match the implementation.

Done.

https://codereview.chromium.org/3005723002/diff/1/tools/gardening/lib/src/luc...
tools/gardening/lib/src/luci_api.dart:30: Future<Try<dynamic>> getCBEJson(
On 2017/08/29 07:23:04, Johnni Winther wrote:
> Rename to [getJsonFromChromeBuildExtract]

Done.

https://codereview.chromium.org/3005723002/diff/1/tools/gardening/lib/src/luc...
tools/gardening/lib/src/luci_api.dart:39: /// Gets master information out for
all bots, which is not that
On 2017/08/29 07:23:04, Johnni Winther wrote:
> Remove ', which is not that useful atm'. Maybe add a TODO for you about want
you
> think it should/could be used for in the future.

Done.