Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 3005683002: Add command line options to rank_stacks (Closed)

Created:
3 years, 3 months ago by sra1
Modified:
3 years, 3 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : better sorting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -27 lines) Patch
M pkg/compiler/tool/status_files/rank_stacks.dart View 1 2 chunks +64 lines, -27 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
sra1
3 years, 3 months ago (2017-08-26 01:12:21 UTC) #3
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/3005683002/diff/20001/pkg/compiler/tool/status_files/rank_stacks.dart File pkg/compiler/tool/status_files/rank_stacks.dart (right): https://codereview.chromium.org/3005683002/diff/20001/pkg/compiler/tool/status_files/rank_stacks.dart#newcode51 pkg/compiler/tool/status_files/rank_stacks.dart:51: if ((m = new RegExp(r'(--stacks=|-s)(\d+)$').matchAsPrefix(arg)) != null) { ...
3 years, 3 months ago (2017-08-26 02:09:00 UTC) #4
sra1
https://codereview.chromium.org/3005683002/diff/20001/pkg/compiler/tool/status_files/rank_stacks.dart File pkg/compiler/tool/status_files/rank_stacks.dart (right): https://codereview.chromium.org/3005683002/diff/20001/pkg/compiler/tool/status_files/rank_stacks.dart#newcode51 pkg/compiler/tool/status_files/rank_stacks.dart:51: if ((m = new RegExp(r'(--stacks=|-s)(\d+)$').matchAsPrefix(arg)) != null) { On ...
3 years, 3 months ago (2017-08-29 19:53:03 UTC) #6
sra1
3 years, 3 months ago (2017-08-29 19:56:20 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:60001) manually as
c65d94d44006f1f9d36e2f034dcc20a3b742aaac (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698