Issue 3005623002: Revert "Puts TLABs back into the build and fixes assert failure."

Issue 3005623002: Revert "Puts TLABs back into the build and fixes assert failure." (Closed)

Created:
3 years, 3 months ago by rmacnak

Modified:
3 years, 3 months ago

Reviewers:
danunez, siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "Puts TLABs back into the build and fixes assert failure." This reverts commit 4c471b3f2733529d1b263596550b9bae3b38d88c. This change regressed Flutter's velocity tracker benchmark by ~15%; reverting until this can be fixed or understood. Issue #30521 R=danunez@google.com Committed: https://github.com/dart-lang/sdk/commit/e9d358921dddbee84c39c951220d5a844b097bb5

Created: 3 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+54 lines, -164 lines)			Patch
M	runtime/vm/heap.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	runtime/vm/heap.cc	View	2 chunks	+9 lines, -58 lines	0 comments	Download
M	runtime/vm/isolate.cc	View	2 chunks	+10 lines, -0 lines	0 comments	Download
M	runtime/vm/scavenger.h	View	8 chunks	+6 lines, -32 lines	0 comments	Download
M	runtime/vm/scavenger.cc	View	10 chunks	+27 lines, -67 lines	0 comments	Download
M	runtime/vm/thread.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/thread_registry.h	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 5 (2 generated)

rmacnak

3 years, 3 months ago (2017-08-25 17:48:28 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
e9d358921dddbee84c39c951220d5a844b097bb5 (presubmit successful).