Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 3005583002: More status files updates after https://codereview.chromium.org/3001803002/ (Closed)

Created:
3 years, 4 months ago by Emily Fortuna
Modified:
3 years, 3 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M tests/language/language_dart2js.status View 1 chunk +0 lines, -1 line 0 comments Download
M tests/language_2/language_2_dart2js.status View 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Emily Fortuna
TBR let's try this again O.O
3 years, 4 months ago (2017-08-25 06:43:54 UTC) #2
Emily Fortuna
Committed patchset #1 (id:1) manually as 69e7c5394821ba4f3b941e05da70629df8ffe0b8 (presubmit successful).
3 years, 4 months ago (2017-08-25 06:44:12 UTC) #4
Bob Nystrom
3 years, 3 months ago (2017-08-25 15:31:36 UTC) #5
Message was sent while issue was closed.
LGTM.

Is there another configuration we should run when migrating tests to catch cases
like this?

Powered by Google App Engine
This is Rietveld 408576698