Issue 3005573002: Revert "Remove check for scheme in source-loader."

Issue 3005573002: Revert "Remove check for scheme in source-loader." (Closed)

Created:
3 years, 3 months ago by Siggi Cherem (dart-lang)

Modified:
3 years, 3 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org, dart-uxr+reviews_google.com, dart-fe-team+reviews_google.com, Johnni Winther

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "Remove check for scheme in source-loader." This triggered some failures on the vm bots, I'll hopefully reland tomorrow morning. This reverts commit d9ae60e14fdec52bda977ed114f6ad70dc2f0bc4. Committed: https://github.com/dart-lang/sdk/commit/752df5edb9d7789ea3ae10eea664aa90a67b802f

Created: 3 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -33 lines)			Patch
M	pkg/front_end/lib/src/fasta/fasta_codes_generated.dart	View	1 chunk	+0 lines, -21 lines	0 comments	Download
M	pkg/front_end/lib/src/fasta/source/source_loader.dart	View	3 chunks	+3 lines, -9 lines	0 comments	Download
M	pkg/front_end/messages.yaml	View	1 chunk	+0 lines, -3 lines	0 comments	Download

Total messages: 5 (3 generated)

Siggi Cherem (dart-lang)

Committed patchset #1 (id:1) manually as 752df5edb9d7789ea3ae10eea664aa90a67b802f (presubmit successful).

3 years, 3 months ago (2017-08-25 04:40:48 UTC) #2

Message was sent while issue was closed.

tbr