Fix the return type of String.split in DDC to be correct

Fix the return type of String.split in DDC to be correct

It wasn't actually a List<String>, so it could fail a strong mode cast, and also permitted non-Strings to be added.

R=leafp@google.com

Committed: https://github.com/dart-lang/sdk/commit/d0072fa73fcb5421e49ba7e86818b891c70303d8

[Jennifer Messerly, 2017-08-24 17:10:08]

jmesserly@google.com changed reviewers:
+ leafp@google.com, vsm@google.com

[Leaf, 2017-08-24 17:30:09]

lgtm

https://codereview.chromium.org/3005533002/diff/1/tests/corelib_2/corelib_2.s...
File tests/corelib_2/corelib_2.status (right):

https://codereview.chromium.org/3005533002/diff/1/tests/corelib_2/corelib_2.s...
tests/corelib_2/corelib_2.status:183: int_parse_radix_test/02: RuntimeError
File a bug for these?

[Jennifer Messerly, 2017-08-25 18:25:01]

Description was changed from

==========
Fix the return type of String.split in DDC to be correct

It wasn't actually a List<String>, so it could fail a strong mode cast, and also
permitted non-Strings to be added.
==========

to

==========
Fix the return type of String.split in DDC to be correct

It wasn't actually a List<String>, so it could fail a strong mode cast, and also
permitted non-Strings to be added.

R=leafp@google.com

Committed:
https://github.com/dart-lang/sdk/commit/d0072fa73fcb5421e49ba7e86818b891c70303d8
==========

[Jennifer Messerly, 2017-08-25 18:25:02]

Committed patchset #1 (id:1) manually as
d0072fa73fcb5421e49ba7e86818b891c70303d8 (presubmit successful).

[Jennifer Messerly, 2017-08-25 18:27:30]

thanks! i filed https://github.com/dart-lang/sdk/issues/30548