Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(990)

Unified Diff: src/ports/SkAtomics_win.h

Issue 300553003: Implement sk_atomic_conditional_inc with sk_atomic_cas. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: inline Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ports/SkAtomics_sync.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ports/SkAtomics_win.h
diff --git a/src/ports/SkAtomics_win.h b/src/ports/SkAtomics_win.h
index f4d6da4e3e28bdd5ae6c140a0a35962747898d7f..7454d66055157c347c533eb0430f787d87e7352a 100644
--- a/src/ports/SkAtomics_win.h
+++ b/src/ports/SkAtomics_win.h
@@ -36,23 +36,6 @@ static inline int32_t sk_atomic_dec(int32_t* addr) {
static inline void sk_membar_acquire__after_atomic_dec() { }
-static inline int32_t sk_atomic_conditional_inc(int32_t* addr) {
- long value = *addr;
- while (true) {
- if (value == 0) {
- return 0;
- }
-
- long before = _InterlockedCompareExchange(reinterpret_cast<long*>(addr), value + 1, value);
-
- if (before == value) {
- return value;
- } else {
- value = before;
- }
- }
-}
-
static inline bool sk_atomic_cas(int32_t* addr, int32_t before, int32_t after) {
return _InterlockedCompareExchange(reinterpret_cast<long*>(addr), after, before) == before;
}
« no previous file with comments | « src/ports/SkAtomics_sync.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698