Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: src/ports/SkAtomics_sync.h

Issue 300553003: Implement sk_atomic_conditional_inc with sk_atomic_cas. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: inline Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ports/SkAtomics_none.h ('k') | src/ports/SkAtomics_win.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ports/SkAtomics_sync.h
diff --git a/src/ports/SkAtomics_sync.h b/src/ports/SkAtomics_sync.h
index 9a4fe7a6e65f347ab8c91a8306d87eefb08b7c14..45ba63f305c5193dee30eca074123840b0811936 100644
--- a/src/ports/SkAtomics_sync.h
+++ b/src/ports/SkAtomics_sync.h
@@ -26,24 +26,6 @@ static inline __attribute__((always_inline)) int32_t sk_atomic_dec(int32_t* addr
static inline __attribute__((always_inline)) void sk_membar_acquire__after_atomic_dec() { }
-static inline __attribute__((always_inline)) int32_t sk_atomic_conditional_inc(int32_t* addr) {
- int32_t value = *addr;
-
- while (true) {
- if (value == 0) {
- return 0;
- }
-
- int32_t before = __sync_val_compare_and_swap(addr, value, value + 1);
-
- if (before == value) {
- return value;
- } else {
- value = before;
- }
- }
-}
-
static inline __attribute__((always_inline)) bool sk_atomic_cas(int32_t* addr,
int32_t before,
int32_t after) {
« no previous file with comments | « src/ports/SkAtomics_none.h ('k') | src/ports/SkAtomics_win.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698