Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: webrtc/rtc_tools/sanitizers_unittest.cc

Issue 3005273002: Add a check that sanitizers cause a fatal failure (Closed)
Patch Set: Rebase Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/rtc_tools/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/rtc_tools/sanitizers_unittest.cc
diff --git a/webrtc/rtc_tools/sanitizers_unittest.cc b/webrtc/rtc_tools/sanitizers_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..74cb081efa8337e5ce5ee07695791b750a7276fb
--- /dev/null
+++ b/webrtc/rtc_tools/sanitizers_unittest.cc
@@ -0,0 +1,121 @@
+/*
+ * Copyright (c) 2017 The WebRTC project authors. All Rights Reserved.
+ *
+ * Use of this source code is governed by a BSD-style license
+ * that can be found in the LICENSE file in the root of the source
+ * tree. An additional intellectual property rights grant can be found
+ * in the file PATENTS. All contributing project authors may
+ * be found in the AUTHORS file in the root of the source tree.
+ */
+
+#include <stddef.h>
+#include <stdio.h>
+#include <random>
+
+#include "webrtc/rtc_base/checks.h"
+#include "webrtc/rtc_base/nullsocketserver.h"
+#include "webrtc/rtc_base/ptr_util.h"
+#include "webrtc/rtc_base/thread.h"
+#include "webrtc/test/gtest.h"
+
+namespace rtc {
+
+namespace {
+
+#if defined(MEMORY_SANITIZER)
+void UseOfUninitializedValue() {
+ int* buf = new int[2];
+ std::random_device engine;
+ if (buf[engine() % 2]) { // Non-deterministic conditional.
+ printf("Externally visible action.");
+ }
+ delete[] buf;
+}
+
+TEST(SanitizersDeathTest, MemorySanitizer) {
+ EXPECT_DEATH(UseOfUninitializedValue(), "use-of-uninitialized-value");
+}
+#endif
+
+#if defined(ADDRESS_SANITIZER)
+void HeapUseAfterFree() {
+ char *buf = new char[2];
+ delete[] buf;
+ buf[0] = buf[1];
+}
+
+TEST(SanitizersDeathTest, AddressSanitizer) {
+ EXPECT_DEATH(HeapUseAfterFree(), "heap-use-after-free");
+}
+#endif
+
+#if defined(UNDEFINED_SANITIZER)
+// For ubsan:
+void SignedIntegerOverflow() {
+ int32_t x = 1234567890;
+ x *= 2;
+}
+
+// For ubsan_vptr:
+struct Base {
+ virtual void f() {}
+ virtual ~Base() {}
+};
+struct Derived : public Base {
+};
+
+void InvalidVptr() {
+ Base b;
+ auto* d = static_cast<Derived*>(&b); // Bad downcast.
+ d->f(); // Virtual function call with object of wrong dynamic type.
+}
+
+TEST(SanitizersDeathTest, UndefinedSanitizer) {
+ EXPECT_DEATH({ SignedIntegerOverflow(); InvalidVptr(); }, "runtime error");
+}
+#endif
+
+#if defined(THREAD_SANITIZER)
+class IncrementThread : public Thread {
+ public:
+ explicit IncrementThread(int* value)
+ : Thread(rtc::MakeUnique<NullSocketServer>()),
+ value_(value) {}
+
+ void Run() override {
+ ++*value_;
+ Thread::Current()->SleepMs(100);
+ }
+
+ // Un-protect Thread::Join for the test.
+ void Join() {
+ Thread::Join();
+ }
+
+ private:
+ int* value_;
+
+ RTC_DISALLOW_COPY_AND_ASSIGN(IncrementThread);
+};
+
+void DataRace() {
+ int value = 0;
+ IncrementThread thread1(&value);
+ IncrementThread thread2(&value);
+ thread1.Start();
+ thread2.Start();
+ thread1.Join();
+ thread2.Join();
+ // TSan seems to mess with gtest's death detection.
+ // Fail intentionally, and rely on detecting the error message.
+ RTC_CHECK(false);
+}
+
+TEST(SanitizersDeathTest, ThreadSanitizer) {
+ EXPECT_DEATH(DataRace(), "data race");
+}
+#endif
+
+} // namespace
+
+} // namespace rtc
« no previous file with comments | « webrtc/rtc_tools/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698