Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(711)

Unified Diff: scripts/master/factory/nacl_commands.py

Issue 3005048: Land http://codereview.chromium.org/2998005/show -- Update Memcheck command... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/buildbot/
Patch Set: Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | scripts/master/factory/nacl_factory.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/master/factory/nacl_commands.py
===================================================================
--- scripts/master/factory/nacl_commands.py (revision 54715)
+++ scripts/master/factory/nacl_commands.py (working copy)
@@ -518,20 +518,30 @@
env=self._build_env,
locks=[self.slave_exclusive_lock])
- def AddValgrind(self, options=None):
- """Add a valgrind test step."""
+ def AddMemcheck(self, options=None):
+ """Add a Memcheck test step."""
cmd = ('%s platform=x86-64 sdl=none '
- 'run_under=src/third_party/valgrind/bin/memcheck.sh,'
- '--log-file=mc.log scale_timeout=20 '
- 'run_hello_world_test') % self._test_tool
+ 'buildbot=memcheck memcheck_bot_tests') % self._test_tool
self.AddTestStep(
shell.ShellCommand,
- test_name='valgrind', timeout=10000,
+ test_name='memcheck', timeout=10000,
test_command=cmd,
workdir='build/native_client',
env=self._build_env,
locks=[self.slave_exclusive_lock])
+ def AddThreadSanitizer(self, options=None):
+ """Add a ThreadSanitizer test step."""
+ cmd = ('%s platform=x86-64 sdl=none '
+ 'buildbot=tsan tsan_bot_tests') % self._test_tool
+ self.AddTestStep(
+ shell.ShellCommand,
+ test_name='tsan', timeout=10000,
+ test_command=cmd,
+ workdir='build/native_client',
+ env=self._build_env,
+ locks=[self.slave_exclusive_lock])
+
def DropDoxygen(self):
"""Adds a step to drop doxygen from the tarballs."""
if self._target_platform.startswith('win'):
« no previous file with comments | « no previous file | scripts/master/factory/nacl_factory.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698