Issue 3005018: Load the download animation image as an NSImage rather than a CGImageRef.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3005018: Load the download animation image as an NSImage rather than a CGImageRef. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 10 months ago by Robert Sesek

Modified:
4 years ago

Reviewers:
Nico

CC:
chromium-reviews, John Grabowski, Paul Godavari, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Load the download animation image as an NSImage rather than a CGImageRef. BUG=none TEST=ui_tests don't crash Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52982

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -6 lines)			Patch
	M	chrome/browser/cocoa/animatable_image.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	chrome/browser/cocoa/download_started_animation_mac.mm	View		3 chunks	+4 lines, -5 lines	0 comments	Download

Trybot results:

Total messages: 2 (0 generated)

Nico

4 years, 10 months ago (2010-07-20 01:09:22 UTC) #2

LG

I hope there was a test that caught this? If not, add one? :-)