Chromium Code Reviews| Index: tools/testing/dart/options.dart |
| diff --git a/tools/testing/dart/options.dart b/tools/testing/dart/options.dart |
| index 26a687a8a9283649cc994aebb2165495d4849a51..bf9f14d7c1d520e06349b5d3e142fe478dbc2f3c 100644 |
| --- a/tools/testing/dart/options.dart |
| +++ b/tools/testing/dart/options.dart |
| @@ -233,6 +233,9 @@ is tested. |
| // TODO(rnystrom): This does not appear to be used. Remove? |
| new _Option('build_directory', |
| 'The name of the build directory, where products are placed.'), |
| + new _Option('debug_output_directory', |
| + 'The name of the output directory for storing debug and log files.', |
|
Bill Hesse
2017/09/01 11:56:13
for storing log files. Does any other output actu
mkroghj
2017/09/04 10:43:34
Done.
|
| + defaultsTo: "debug"), |
|
Bill Hesse
2017/09/01 11:56:13
default "logs"?
mkroghj
2017/09/04 10:43:34
Done.
|
| new _Option.bool('noBatch', 'Do not run tests in batch mode.', 'n'), |
| new _Option.bool('dart2js_batch', 'Run dart2js tests in batch mode.'), |
| new _Option.bool( |
| @@ -241,6 +244,10 @@ is tested. |
| 'Don\'t write debug messages to stdout but rather to a logfile.'), |
| new _Option.bool('write_test_outcome_log', |
| 'Write test outcomes to a "${TestUtils.testOutcomeFileName}" file.'), |
| + new _Option.bool( |
| + 'write_result_json_log', |
| + 'Write test results to a "${TestUtils.testResultFileName}" json file ' |
|
Bill Hesse
2017/09/01 11:56:13
.resultLogFileName
mkroghj
2017/09/04 10:43:34
Done.
|
| + 'located at the debug_output_directory.'), |
| new _Option.bool('reset_browser_configuration', |
| '''Browser specific reset of configuration. |
| @@ -290,6 +297,7 @@ compiler.''') |
| static final _blacklistedOptions = [ |
| 'append_logs', |
| 'build_directory', |
| + 'debug_output_directory', |
| 'chrome', |
| 'copy_coredumps', |
| 'dart', |
| @@ -309,6 +317,7 @@ compiler.''') |
| 'verbose', |
| 'write_debug_log', |
| 'write_test_outcome_log', |
| + 'write_result_json_log' |
| ].toSet(); |
| /// Parses a list of strings as test options. |
| @@ -600,6 +609,7 @@ compiler.''') |
| data["dart2js_with_kernel_in_ssa"] as bool, |
| writeDebugLog: data["write_debug_log"] as bool, |
| writeTestOutcomeLog: data["write_test_outcome_log"] as bool, |
| + writeResultJsonLog: data["write_result_json_log"] as bool, |
| drtPath: data["drt"] as String, |
| chromePath: data["chrome"] as String, |
| safariPath: data["safari"] as String, |
| @@ -623,6 +633,7 @@ compiler.''') |
| packageRoot: data["package_root"] as String, |
| suiteDirectory: data["suite_dir"] as String, |
| builderTag: data["builder_tag"] as String, |
| + debugOutputDirectory: data["debug_output_directory"] as String, |
| reproducingArguments: _reproducingCommand(data)); |
| if (configuration.validate()) { |