Chromium Code Reviews| Index: tools/testing/dart/configuration.dart |
| diff --git a/tools/testing/dart/configuration.dart b/tools/testing/dart/configuration.dart |
| index 4e1723aeff5a70553d2878c3eacf65c12a5528f2..97481cd1fe90c3c89bd5cb1c339c2ea7f145b85a 100644 |
| --- a/tools/testing/dart/configuration.dart |
| +++ b/tools/testing/dart/configuration.dart |
| @@ -52,6 +52,7 @@ class Configuration { |
| this.useDart2JSWithKernelInSsa, |
| this.writeDebugLog, |
| this.writeTestOutcomeLog, |
| + this.writeResultJsonLog, |
|
Bill Hesse
2017/09/01 11:56:13
Just writeResultLog, I think.
mkroghj
2017/09/04 10:43:34
Done.
|
| this.drtPath, |
| this.chromePath, |
| this.safariPath, |
| @@ -74,6 +75,7 @@ class Configuration { |
| this.packageRoot, |
| this.suiteDirectory, |
| this.builderTag, |
| + this.debugOutputDirectory, |
|
Bill Hesse
2017/09/01 11:56:13
I wouldn't call it debugOutput, just output.
mkroghj
2017/09/04 10:43:34
Done.
|
| this.reproducingArguments}) |
| : _packages = packages, |
| _timeout = timeout; |
| @@ -115,6 +117,7 @@ class Configuration { |
| final bool useDart2JSWithKernelInSsa; |
| final bool writeDebugLog; |
| final bool writeTestOutcomeLog; |
| + final bool writeResultJsonLog; |
| // Various file paths. |
| @@ -152,6 +155,7 @@ class Configuration { |
| return _packages; |
| } |
| + final String debugOutputDirectory; |
| final String packageRoot; |
| final String suiteDirectory; |
| final String builderTag; |
| @@ -419,6 +423,30 @@ class Configuration { |
| return normal; |
| } |
| + |
| + /// [toSummaryMap] returns a map of configurations important to the running |
| + /// of a test. Flags and properties used for output is not included. |
|
Bill Hesse
2017/09/01 11:56:13
are not included
mkroghj
2017/09/04 10:43:34
Done.
|
| + /// Boolean flags that are false are not included in the map. The summary map |
| + /// can be used to serialize to json for test-output logging. |
| + Map toSummaryMap() { |
| + return { |
| + 'mode': mode.name, |
| + 'arch': architecture.name, |
| + 'compiler': compiler.name, |
| + 'runtime': runtime.name, |
| + 'checked': isChecked, |
| + 'strong': isStrong, |
| + 'host_checked': isHostChecked, |
| + 'minified': isMinified, |
| + 'csp': isCsp, |
| + 'system': system.name, |
| + 'vm_options': vmOptions, |
| + 'use_sdk': useSdk, |
| + 'builder_tag': builderTag, |
| + 'fast_startup': useFastStartup, |
| + 'timeout': timeout |
| + }; |
| + } |
| } |
| class Architecture { |