Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(854)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 3004973002: Revert "Store actual Reference(s) for additional exports." (Closed)

Created:
3 years, 3 months ago by ahe
Modified:
3 years, 3 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Store actual Reference(s) for additional exports." This reverts commit 234c4a7f493e1fc3dafc393472e39163ac2ad783. Revert "Fix for ScopeBuilder[] - look into setters too." This reverts commit 7924f4c42fa6546260136ac2689f004be24c2268. Revert "Don't include BuiltinTypeBuilder(s) into additional exports." This reverts commit e28aac09c4d74744a6e7dea0c046f6a37c7c24fe. The reason for reverting is that the two follow-up commits aren't correct. R=johnniwinther@google.com Committed: https://github.com/dart-lang/sdk/commit/f0277b32e82828069e5b20fa7ca448215cba15b1

Patch Set 1 #

Patch Set 2 : Update status file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -156 lines) Patch
M pkg/front_end/lib/src/fasta/dill/dill_library_builder.dart View 5 chunks +37 lines, -28 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart View 2 chunks +6 lines, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/scope.dart View 1 chunk +1 line, -3 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/source_library_builder.dart View 5 chunks +19 lines, -9 lines 0 comments Download
A pkg/front_end/test/fasta/ambiguous_export_test.dart View 1 chunk +41 lines, -0 lines 0 comments Download
M pkg/front_end/test/src/incremental/kernel_driver_test.dart View 1 chunk +5 lines, -21 lines 0 comments Download
M pkg/front_end/testcases/ambiguous_exports.dart.direct.expect View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/ambiguous_exports.dart.outline.expect View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/ambiguous_exports.dart.strong.expect View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/export_main.dart.direct.expect View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/export_main.dart.outline.expect View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/export_main.dart.strong.expect View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/export_test.dart.direct.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/export_test.dart.outline.expect View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/front_end/testcases/export_test.dart.strong.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/rasta/export.dart.direct.expect View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/rasta/export.dart.outline.expect View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/rasta/export.dart.strong.expect View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/kernel/binary.md View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/kernel/lib/ast.dart View 1 chunk +0 lines, -6 lines 0 comments Download
M pkg/kernel/lib/binary/ast_from_binary.dart View 2 chunks +0 lines, -12 lines 0 comments Download
M pkg/kernel/lib/binary/ast_to_binary.dart View 2 chunks +0 lines, -8 lines 0 comments Download
M pkg/kernel/lib/binary/limited_ast_to_binary.dart View 1 chunk +0 lines, -8 lines 0 comments Download
M pkg/kernel/lib/import_table.dart View 1 chunk +0 lines, -7 lines 0 comments Download
M pkg/kernel/lib/text/ast_to_text.dart View 1 chunk +0 lines, -28 lines 0 comments Download
M runtime/vm/kernel_binary_flowgraph.h View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/kernel_binary_flowgraph.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M tests/language_2/language_2_kernel.status View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
ahe
3 years, 3 months ago (2017-08-31 13:03:57 UTC) #2
Johnni Winther
lgtm
3 years, 3 months ago (2017-08-31 13:20:21 UTC) #3
ahe
3 years, 3 months ago (2017-08-31 14:13:57 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:2) manually as
f0277b32e82828069e5b20fa7ca448215cba15b1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698