Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Unified Diff: pkg/front_end/lib/src/fasta/kernel/kernel_outline_shaker.dart

Issue 3004943002: Transitively include outlines of all public members of Class(es). (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/front_end/testcases/shaker/empty_program.dart.shaker » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/front_end/lib/src/fasta/kernel/kernel_outline_shaker.dart
diff --git a/pkg/front_end/lib/src/fasta/kernel/kernel_outline_shaker.dart b/pkg/front_end/lib/src/fasta/kernel/kernel_outline_shaker.dart
index ea88a085c9cc5f62d146e48081f74084372e9abb..0b5fc67985587178383e5ec233e0c18a613f75bb 100644
--- a/pkg/front_end/lib/src/fasta/kernel/kernel_outline_shaker.dart
+++ b/pkg/front_end/lib/src/fasta/kernel/kernel_outline_shaker.dart
@@ -100,10 +100,15 @@ class RetainedDataBuilder extends RetainedData {
markLibrary(cls.parent);
// TODO(sigmund): retain annotations?
// visitList(cls.annotations, this);
+ cls.typeParameters.forEach((t) => t.bound.accept(typeMarker));
markSupertype(cls.supertype);
markSupertype(cls.mixedInType);
cls.implementedTypes.forEach(markSupertype);
- cls.typeParameters.forEach((t) => t.bound.accept(typeMarker));
+ cls.members.forEach((member) {
+ if (!member.name.isPrivate) {
+ markMember(member);
Paul Berry 2017/08/30 21:46:45 I think we should exclude constructors and static
+ }
+ });
}
/// Mark the typedef.
« no previous file with comments | « no previous file | pkg/front_end/testcases/shaker/empty_program.dart.shaker » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698