Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 3004943002: Transitively include outlines of all public members of Class(es). (Closed)

Created:
3 years, 3 months ago by scheglov
Modified:
3 years, 3 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Include only referenced constructor and static class members. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+509 lines, -19 lines) Patch
M pkg/front_end/lib/src/fasta/kernel/kernel_outline_shaker.dart View 1 1 chunk +12 lines, -1 line 0 comments Download
M pkg/front_end/testcases/shaker/empty_program.dart.shaker View 1 2 chunks +400 lines, -0 lines 0 comments Download
A + pkg/front_end/testcases/shaker/target_class_constructor.dart View 1 1 chunk +4 lines, -4 lines 0 comments Download
A pkg/front_end/testcases/shaker/target_class_constructor.dart.shaker View 1 1 chunk +11 lines, -0 lines 0 comments Download
A + pkg/front_end/testcases/shaker/target_class_constructor_lib.dart View 1 1 chunk +15 lines, -3 lines 0 comments Download
A + pkg/front_end/testcases/shaker/target_class_static.dart View 1 1 chunk +7 lines, -4 lines 0 comments Download
A pkg/front_end/testcases/shaker/target_class_static.dart.shaker View 1 1 chunk +9 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/shaker/target_class_static_lib.dart View 1 1 chunk +17 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/shaker/transitive_class.dart.shaker View 1 1 chunk +8 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/shaker/transitive_class_constructor.dart.shaker View 1 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/shaker/transitive_class_lib.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/shaker/transitive_class_type_parameter_bound.dart.shaker View 1 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/shaker/transitive_class_type_parameter_bound_lib.dart View 1 1 chunk +9 lines, -3 lines 0 comments Download
M pkg/front_end/testcases/shaker/transitive_superclass.dart.shaker View 1 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/shaker/transitive_superclass_lib.dart View 1 1 chunk +9 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
scheglov
3 years, 3 months ago (2017-08-30 21:02:42 UTC) #1
Paul Berry
https://codereview.chromium.org/3004943002/diff/1/pkg/front_end/lib/src/fasta/kernel/kernel_outline_shaker.dart File pkg/front_end/lib/src/fasta/kernel/kernel_outline_shaker.dart (right): https://codereview.chromium.org/3004943002/diff/1/pkg/front_end/lib/src/fasta/kernel/kernel_outline_shaker.dart#newcode109 pkg/front_end/lib/src/fasta/kernel/kernel_outline_shaker.dart:109: markMember(member); I think we should exclude constructors and static ...
3 years, 3 months ago (2017-08-30 21:46:45 UTC) #2
scheglov
PTAL
3 years, 3 months ago (2017-08-31 04:28:10 UTC) #3
Paul Berry
lgtm
3 years, 3 months ago (2017-08-31 15:43:49 UTC) #4
scheglov
3 years, 3 months ago (2017-08-31 18:35:14 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
39b921ecce35656f4e71844a9b1b73eddbbf6947 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698