Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 3004923002: Rename front end shadow classes from "Kernel..." to "Shadow...". (Closed)

Created:
3 years, 3 months ago by Paul Berry
Modified:
3 years, 3 months ago
Reviewers:
ahe, scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Rename front end shadow classes from "Kernel..." to "Shadow...". This should reduce confusion, since these classes are specifically *not* part of kernel. I also went ahead and renamed a few classes that aren't shadow classes but are related to the shadow classes, e.g. KernelTypeInferrer -> ShadowTypeInferrer. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/a5b3cbac13a00370cf6045182fce6c3b325ea32e

Patch Set 1 #

Messages

Total messages: 6 (2 generated)
Paul Berry
This is a big CL but hopefully any merge conflicts it introduces should be easy ...
3 years, 3 months ago (2017-08-30 19:16:48 UTC) #2
scheglov
LGTM
3 years, 3 months ago (2017-08-30 19:25:33 UTC) #3
Paul Berry
Committed patchset #1 (id:1) manually as a5b3cbac13a00370cf6045182fce6c3b325ea32e (presubmit successful).
3 years, 3 months ago (2017-08-30 20:10:30 UTC) #5
ahe
3 years, 3 months ago (2017-08-31 10:46:58 UTC) #6
Message was sent while issue was closed.
lgtm

Thank you. I'm glad I was *thinking* about how to implement patching yesterday,
so I'm not impacted by this rename :-)

Powered by Google App Engine
This is Rietveld 408576698