Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 3004903002: Fixed strong mode error in slow_consumer3_test introduced as part of Dart 2.0 migration (test block… (Closed)

Created:
3 years, 3 months ago by bkonyi
Modified:
3 years, 3 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fixed strong mode error in slow_consumer3_test introduced as part of Dart 2.0 migration (test block 171). TBR=rnystrom@google.com,jcollins@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/e897f75c74b1efa2bb7b5c12d57028ebd9f7b20e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tests/lib_2/async/slow_consumer3_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
bkonyi
Committed patchset #1 (id:1) manually as e897f75c74b1efa2bb7b5c12d57028ebd9f7b20e (presubmit successful).
3 years, 3 months ago (2017-08-30 14:06:18 UTC) #2
Dmitry Stefantsov
LGTM
3 years, 3 months ago (2017-08-30 14:08:58 UTC) #4
Bob Nystrom
3 years, 3 months ago (2017-08-30 17:16:10 UTC) #5
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698