Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 3004803002: Include web_components in the isolate file. (Closed)

Created:
3 years, 3 months ago by Alexander Thomas
Modified:
3 years, 3 months ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org, rmacnak
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Include web_components in the isolate file. Update tests to use web_components from the isolated location. BUG= R=whesse@google.com Committed: https://github.com/dart-lang/sdk/commit/b7ef001fec0eacd6451ae71746d0a0ef090aac59

Patch Set 1 #

Patch Set 2 : Remove incorrect updates to test files. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tools/bots/dart_tests.isolate View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Alexander Thomas
3 years, 3 months ago (2017-08-29 13:57:42 UTC) #2
Bill Hesse
lgtm
3 years, 3 months ago (2017-08-29 15:12:05 UTC) #3
Alexander Thomas
3 years, 3 months ago (2017-08-29 15:13:22 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
b7ef001fec0eacd6451ae71746d0a0ef090aac59 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698