Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 3004763002: Add variable declaration support to the DeclaredIdentifier AST node in the Kythe Dart indexer. (Closed)

Created:
3 years, 3 months ago by jwren
Modified:
3 years, 3 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add variable declaration support to the DeclaredIdentifier AST node in the Kythe Dart indexer. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/96ee1d846dc47be124914bb0cf1e4044fada2aad

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -0 lines) Patch
M pkg/analysis_server/lib/src/services/kythe/kythe_visitors.dart View 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
jwren
3 years, 3 months ago (2017-08-28 17:22:50 UTC) #2
Brian Wilkerson
lgtm
3 years, 3 months ago (2017-08-28 17:24:26 UTC) #3
jwren
3 years, 3 months ago (2017-08-28 17:25:32 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
96ee1d846dc47be124914bb0cf1e4044fada2aad (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698