Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Issue 3004733002: Add folding support for plugins and update the main tutorial page (Closed)

Created:
3 years, 3 months ago by Brian Wilkerson
Modified:
3 years, 3 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add folding support for plugins and update the main tutorial page R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/608bf972b0529eba9d908806844f836ab9e1ead2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+433 lines, -0 lines) Patch
A pkg/analyzer_plugin/doc/tutorial/folding.md View 1 chunk +79 lines, -0 lines 0 comments Download
M pkg/analyzer_plugin/doc/tutorial/tutorial.md View 1 chunk +16 lines, -0 lines 0 comments Download
A pkg/analyzer_plugin/lib/plugin/folding_mixin.dart View 1 chunk +68 lines, -0 lines 0 comments Download
A pkg/analyzer_plugin/lib/src/utilities/folding/folding.dart View 1 chunk +54 lines, -0 lines 0 comments Download
A pkg/analyzer_plugin/lib/utilities/folding/folding.dart View 1 chunk +114 lines, -0 lines 0 comments Download
A pkg/analyzer_plugin/test/plugin/folding_mixin_test.dart View 1 chunk +100 lines, -0 lines 0 comments Download
M pkg/analyzer_plugin/test/plugin/test_all.dart View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
3 years, 3 months ago (2017-08-28 14:30:55 UTC) #2
scheglov
LGTM
3 years, 3 months ago (2017-08-28 14:59:45 UTC) #3
Brian Wilkerson
3 years, 3 months ago (2017-08-28 15:05:43 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
608bf972b0529eba9d908806844f836ab9e1ead2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698