Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 3004713002: Remove use of Compiler in inferrer engines. (Closed)

Created:
3 years, 3 months ago by Johnni Winther
Modified:
3 years, 3 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+230 lines, -144 lines) Patch
M pkg/compiler/lib/src/compiler.dart View 10 chunks +61 lines, -33 lines 0 comments Download
M pkg/compiler/lib/src/dump_info.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/ast_inferrer_engine.dart View 1 chunk +14 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/inferrer_engine.dart View 11 chunks +78 lines, -27 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/kernel_inferrer_engine.dart View 5 chunks +34 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/node_tracer.dart View 4 chunks +4 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/type_graph_dump.dart View 3 chunks +4 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/type_graph_inferrer.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/type_graph_nodes.dart View 6 chunks +7 lines, -12 lines 0 comments Download
M pkg/compiler/lib/src/io/source_map_builder.dart View 3 chunks +3 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 2 chunks +1 line, -28 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart View 3 chunks +5 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/lazy_emitter/model_emitter.dart View 2 chunks +6 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/startup_emitter/model_emitter.dart View 3 chunks +5 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/tracer.dart View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 3 months ago (2017-08-28 12:32:24 UTC) #2
Siggi Cherem (dart-lang)
lgtm
3 years, 3 months ago (2017-08-28 22:41:12 UTC) #3
Johnni Winther
3 years, 3 months ago (2017-08-29 10:34:10 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
563282bf2cf9a1a2bc73a8c88bc4e73747c29336 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698