Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 3004693002: [kernel] Add offset to SwitchContinueStatement; add debugging test (Closed)

Created:
3 years, 3 months ago by jensj
Modified:
3 years, 3 months ago
CC:
reviews_dartlang.org, turnidge, rmacnak, dart-fe-team+reviews_google.com, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[kernel] Add offset to SwitchContinueStatement; add debugging test BUG= R=johnniwinther@google.com Committed: https://github.com/dart-lang/sdk/commit/1ad24e4b46a36bd450bace39ab09f0b2a1479d13

Patch Set 1 #

Patch Set 2 : ... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -5 lines) Patch
M pkg/front_end/lib/src/fasta/kernel/body_builder.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M pkg/kernel/binary.md View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/kernel/lib/binary/ast_from_binary.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/kernel/lib/binary/ast_to_binary.dart View 1 chunk +1 line, -0 lines 0 comments Download
A runtime/observatory/tests/service/step_through_switch_with_continue_test.dart View 1 chunk +57 lines, -0 lines 0 comments Download
M runtime/vm/kernel_binary_flowgraph.cc View 4 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
jensj
3 years, 3 months ago (2017-08-28 08:58:01 UTC) #2
Johnni Winther
lgtm
3 years, 3 months ago (2017-08-28 09:59:59 UTC) #3
jensj
3 years, 3 months ago (2017-08-28 10:01:12 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
1ad24e4b46a36bd450bace39ab09f0b2a1479d13 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698