Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Unified Diff: pkg/analyzer/test/generated/parser_fasta_test.dart

Issue 3004683002: report abstract as extraneous modifier (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/test/generated/parser_fasta_test.dart
diff --git a/pkg/analyzer/test/generated/parser_fasta_test.dart b/pkg/analyzer/test/generated/parser_fasta_test.dart
index 7682e2fba192efaacc6770ab59d93d10fc2d92ef..679dd0a4b70ad863d89d4ca116341b9a97f9b617 100644
--- a/pkg/analyzer/test/generated/parser_fasta_test.dart
+++ b/pkg/analyzer/test/generated/parser_fasta_test.dart
@@ -135,42 +135,12 @@ class ComplexParserTest_Fasta extends FastaParserTestCase
@reflectiveTest
class ErrorParserTest_Fasta extends FastaParserTestCase
with ErrorParserTestMixin {
- @override
- @failingTest
- void test_abstractClassMember_field() {
- super.test_abstractClassMember_field();
- }
-
@override
@failingTest
void test_abstractEnum() {
super.test_abstractEnum();
}
- @override
- @failingTest
- void test_abstractTopLevelFunction_function() {
- super.test_abstractTopLevelFunction_function();
- }
-
- @override
- @failingTest
- void test_abstractTopLevelFunction_getter() {
- super.test_abstractTopLevelFunction_getter();
- }
-
- @override
- @failingTest
- void test_abstractTopLevelFunction_setter() {
- super.test_abstractTopLevelFunction_setter();
- }
-
- @override
- @failingTest
- void test_abstractTopLevelVariable() {
- super.test_abstractTopLevelVariable();
- }
-
@override
@failingTest
void test_abstractTypeDef() {
@@ -2237,12 +2207,8 @@ class FastaParserTestCase extends Object
@override
void assertErrorsWithCodes(List<ErrorCode> expectedErrorCodes) {
- expectedErrorCodes = expectedErrorCodes.map((code) {
- if (code == ParserErrorCode.ABSTRACT_CLASS_MEMBER)
- return ParserErrorCode.EXTRANEOUS_MODIFIER;
- return code;
- }).toList();
- _parserProxy._errorListener.assertErrorsWithCodes(expectedErrorCodes);
+ _parserProxy._errorListener.assertErrorsWithCodes(
+ _toFastaGeneratedAnalyzerErrorCodes(expectedErrorCodes));
}
@override
@@ -2332,7 +2298,8 @@ class FastaParserTestCase extends Object
CompilationUnit unit = parser.parseCompilationUnit(_fastaTokens);
// Assert and return result
- listener.assertErrorsWithCodes(expectedErrorCodes);
+ listener.assertErrorsWithCodes(
+ _toFastaGeneratedAnalyzerErrorCodes(expectedErrorCodes));
expect(unit, isNotNull);
return unit;
}
@@ -2599,6 +2566,16 @@ class FastaParserTestCase extends Object
createParser(source);
return _parserProxy._run(getParseFunction);
}
+
+ List<ErrorCode> _toFastaGeneratedAnalyzerErrorCodes(
+ List<ErrorCode> expectedErrorCodes) =>
+ expectedErrorCodes.map((code) {
+ if (code == ParserErrorCode.ABSTRACT_CLASS_MEMBER ||
+ code == ParserErrorCode.ABSTRACT_TOP_LEVEL_FUNCTION ||
+ code == ParserErrorCode.ABSTRACT_TOP_LEVEL_VARIABLE)
+ return ParserErrorCode.EXTRANEOUS_MODIFIER;
+ return code;
+ }).toList();
}
/**
« no previous file with comments | « no previous file | pkg/front_end/lib/src/fasta/parser/parser.dart » ('j') | pkg/front_end/lib/src/fasta/parser/parser.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698